Skip to content

fix: improves how code access user-agent in the headers #37540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Nov 18, 2025
Merged

fix: improves how code access user-agent in the headers #37540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-rabbits-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes an issue where `user-agent` is not properly extracted from the DDP connection headers
7 changes: 3 additions & 4 deletions apps/meteor/ee/server/lib/deviceManagement/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Users } from '@rocket.chat/models';
import { Accounts } from 'meteor/accounts-base';
import { Meteor } from 'meteor/meteor';
import moment from 'moment';
import type { Headers } from 'node-fetch';
import { UAParser } from 'ua-parser-js';

import * as Mailer from '../../../../app/mailer/server/api';
Expand Down Expand Up @@ -67,9 +66,9 @@ export const listenSessionLogin = () => {
username,
emails: [{ address: email }],
} = user;
// TODO: Find why the httpheaders is being casted to IncomingHttpHeaders instead of Headers
const userAgentString = connection?.httpHeaders && (connection.httpHeaders as unknown as Headers).get('user-agent');
const { browser, os, device, cpu, app } = await uaParser(userAgentString || '');

const userAgentString = connection?.httpHeaders?.['user-agent'] ?? '';
const { browser, os, device, cpu, app } = await uaParser(userAgentString);

const mailData = {
name,
Expand Down
Loading