Skip to content

chore!: remove deprecated voip-freeswitch.extension.assign #37507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliajforesti wants to merge 2 commits into from
Closed

chore!: remove deprecated voip-freeswitch.extension.assign #37507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99254e7
chore: remove deprecated `voip-freeswitch.extension.assign`
juliajforesti Nov 14, 2025
d2a5cc7
chore: changeset
juliajforesti Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-windows-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': major
---

Removes deprecated `voip-freeswitch.extension.assign`
45 changes: 0 additions & 45 deletions apps/meteor/ee/app/api-enterprise/server/voip-freeswitch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { VoipFreeSwitch } from '@rocket.chat/core-services';
import { Users } from '@rocket.chat/models';
import {
isVoipFreeSwitchExtensionAssignProps,
isVoipFreeSwitchExtensionGetDetailsProps,
isVoipFreeSwitchExtensionGetInfoProps,
isVoipFreeSwitchExtensionListProps,
Expand Down Expand Up @@ -62,50 +61,6 @@ API.v1.addRoute(
},
);

API.v1.addRoute(
'voip-freeswitch.extension.assign',
{
authRequired: true,
permissionsRequired: ['manage-voip-extensions'],
validateParams: isVoipFreeSwitchExtensionAssignProps,
deprecation: {
version: '8.0.0',
alternatives: ['/v1/users.update'],
},
license: ['voip-enterprise'],
},
{
async post() {
if (!settings.get('VoIP_TeamCollab_Enabled')) {
throw new Error('error-voip-disabled');
}

const { extension, username } = this.bodyParams;

if (!username) {
return API.v1.notFound();
}

const user = await Users.findOneByUsername(username, { projection: { freeSwitchExtension: 1 } });
if (!user) {
return API.v1.notFound();
}

const existingUser = extension && (await Users.findOneByFreeSwitchExtension(extension, { projection: { _id: 1 } }));
if (existingUser && existingUser._id !== user._id) {
throw new Error('error-extension-not-available');
}

if (extension && user.freeSwitchExtension === extension) {
return API.v1.success();
}

await Users.setFreeSwitchExtension(user._id, extension);
return API.v1.success();
},
},
);

API.v1.addRoute(
'voip-freeswitch.extension.getDetails',
{
Expand Down
24 changes: 0 additions & 24 deletions packages/rest-typings/src/v1/voip-freeswitch/VoipFreeSwitchExtensionAssignProps.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/rest-typings/src/v1/voip-freeswitch/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import type { FreeSwitchExtension } from '@rocket.chat/core-typings';

import type { VoipFreeSwitchExtensionAssignProps } from './VoipFreeSwitchExtensionAssignProps';
import type { VoipFreeSwitchExtensionGetDetailsProps } from './VoipFreeSwitchExtensionGetDetailsProps';
import type { VoipFreeSwitchExtensionGetInfoProps } from './VoipFreeSwitchExtensionGetInfoProps';
import type { VoipFreeSwitchExtensionListProps } from './VoipFreeSwitchExtensionListProps';

export * from './VoipFreeSwitchExtensionAssignProps';
export * from './VoipFreeSwitchExtensionGetDetailsProps';
export * from './VoipFreeSwitchExtensionGetInfoProps';
export * from './VoipFreeSwitchExtensionListProps';
Expand All @@ -17,9 +15,6 @@ export type VoipFreeSwitchEndpoints = {
'/v1/voip-freeswitch.extension.getDetails': {
GET: (params: VoipFreeSwitchExtensionGetDetailsProps) => FreeSwitchExtension & { userId?: string; username?: string; name?: string };
};
'/v1/voip-freeswitch.extension.assign': {
POST: (params: VoipFreeSwitchExtensionAssignProps) => void;
};
'/v1/voip-freeswitch.extension.getRegistrationInfoByUserId': {
GET: (params: VoipFreeSwitchExtensionGetInfoProps) => {
extension: FreeSwitchExtension;
Expand Down
Loading