-
Notifications
You must be signed in to change notification settings - Fork 13.7k
fix(rooms): Update lastMessage to previous valid message on user deletion #37359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NAME-ASHWANIYADAV
wants to merge
9
commits into
RocketChat:develop
Choose a base branch
from
NAME-ASHWANIYADAV:fix/ghost-last-message
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−9
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cc97f4e
fix(rooms): Update lastMessage to previous valid message on user dele…
NAME-ASHWANIYADAV 424332d
Merge branch 'develop' into fix/ghost-last-message
NAME-ASHWANIYADAV 634e191
Merge upstream/develop and resolve conflicts in deleteUser.ts
NAME-ASHWANIYADAV a69b93b
Fix: Remove comments and add index for lastMessage.u._id
NAME-ASHWANIYADAV 54deff7
Fix: Add lastMessage refresh logic to Unlink case and format Rooms.ts
NAME-ASHWANIYADAV 30954f0
Removing Backlashes
NAME-ASHWANIYADAV c4e66cd
Resolving issue
NAME-ASHWANIYADAV fe37fe9
Fix: Address CodeRabbit review (TOCTOU guard, projection, deletedRooms)
NAME-ASHWANIYADAV cb91ea6
Merge upstream/develop and keep both file deletion logic and lastMess…
NAME-ASHWANIYADAV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.