Skip to content

regression: Voice call keypad doesn't stop on safari #37328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tassoevan merged 1 commit into from
Oct 28, 2025
Merged

regression: Voice call keypad doesn't stop on safari #37328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions packages/ui-voip/src/v2/useTonePlayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ class TonePlayer {

// This filter makes the sound more natural
this.filter = this.audioContext.createBiquadFilter();
this.filter.type = 'lowpass';
this.filter.frequency.value = 8000;
this.filter.type = 'bandpass';
this.filter.frequency.value = 4000;

this.gainNode.connect(this.filter);
this.filter.connect(this.destination);
Expand All @@ -54,8 +54,10 @@ class TonePlayer {
lowFrequencyOscillator.frequency.value = lowFreq;
highFrequencyOscillator.frequency.value = highFreq;

lowFrequencyOscillator.start();
highFrequencyOscillator.start();
const startTime = this.audioContext.currentTime;

lowFrequencyOscillator.start(startTime);
highFrequencyOscillator.start(startTime);

// Ensure audio element is playing
if (this.audioElement.paused) {
Expand All @@ -64,12 +66,8 @@ class TonePlayer {
});
}

setTimeout(() => {
lowFrequencyOscillator.stop();
highFrequencyOscillator.stop();
highFrequencyOscillator.disconnect();
lowFrequencyOscillator.disconnect();
}, durationMs ?? 400);
highFrequencyOscillator.stop(startTime + (durationMs ?? 400) / 1000);
lowFrequencyOscillator.stop(startTime + (durationMs ?? 400) / 1000);
}

public destroy() {
Expand Down
Loading