Skip to content

chore: optimize getRoomsWithSingleOwner to stop cursor iteration after assigning new owner #37292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Nov 3, 2025
Merged

chore: optimize getRoomsWithSingleOwner to stop cursor iteration after assigning new owner #37292

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f1d426
chore: optimize getRoomsWithSingleOwner
abhinavkrin Oct 24, 2025
c787054
minor changes
abhinavkrin Oct 24, 2025
de68a5e
Merge branch 'develop' into chore/optimize-getRoomsWithSingleOwner-loop
scuciatto Nov 3, 2025
301815d
Merge branch 'develop' into chore/optimize-getRoomsWithSingleOwner-loop
scuciatto Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/meteor/app/lib/server/functions/getRoomsWithSingleOwner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export async function getSubscribedRoomsForUserWithDetails(
u: { _id: uid },
} of subscribersCursor) {
// If we already changed the owner or this subscription is for the user we are removing, then don't try to give it ownership
if (roomData.shouldChangeOwner || uid === userId) {
if (uid === userId) {
continue;
}
const newOwner = await Users.findOneActiveById(uid, { projection: { _id: 1 } });
Expand All @@ -61,6 +61,7 @@ export async function getSubscribedRoomsForUserWithDetails(

roomData.newOwner = uid;
roomData.shouldChangeOwner = true;
break;
}

// If there's no subscriber available to be the new owner and it's not a public room, we can remove it.
Expand Down
Loading