Skip to content

fix: Add screen reader support to Message search for announcing number of search result matches. #37247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antm-rp wants to merge 15 commits into from
Closed

fix: Add screen reader support to Message search for announcing number of search result matches. #37247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c91cdb8
ks-201: Add accessibility support for screen readers to announce the …
antm-rp Oct 14, 2025
9f5efcc
ks-201: Fixed tabIndex prop as well as minor spelling errors.
antm-rp Oct 16, 2025
214a113
chore: improve voip session handling (#37094)
pierre-lehnen-rc Oct 13, 2025
e2580d2
fix: Pagination not working properly in `UsersInRoleTable` (#37203)
dougfabris Oct 14, 2025
53a5aaa
fix: Message not being translated immediately in Omnichannel room (#3…
dougfabris Oct 14, 2025
bd0b917
feat: Expandable Message Composer (#36920)
MartinSchoeler Oct 14, 2025
d33f0ec
chore: send to client the contact info of who requested a call trans…
pierre-lehnen-rc Oct 14, 2025
8fda700
chore: Use `AvatarStack` instead of `Avatar.Stack` (#37226)
tassoevan Oct 14, 2025
6700183
fix: Real-time monitoring displaying incorrect data (#37103)
aleksandernsilva Oct 15, 2025
48417ad
chore: Use named components instead of `Field.*` (#37228)
tassoevan Oct 15, 2025
09cdc79
chore: Use `InputBoxSkeleton` instead of `InputBox.Skeleton` (#37231)
tassoevan Oct 15, 2025
b3b6f94
chore: new field for ABAC Attributes on user info (#37135)
MartinSchoeler Oct 15, 2025
7f3be48
refactor: Decouple users in role table data from layout (#37184)
dougfabris Oct 15, 2025
a515202
chore: adds deprecation warning on `sendFileLivechatMessage` (#37235)
lucas-a-pelegrino Oct 15, 2025
6c2a8a5
chore: adds deprecation warning on `livechat:setupConnection` (#37218)
lucas-a-pelegrino Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion apps/meteor/client/views/room/contextualBar/MessageSearchTab/components/MessageSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { MessageTypes } from '@rocket.chat/message-types';
import { useSetting, useTranslation, useUserPreference } from '@rocket.chat/ui-contexts';
import type { ReactElement } from 'react';
import { Fragment, memo, useState } from 'react';
import { VisuallyHidden } from 'react-aria';
import { Virtuoso } from 'react-virtuoso';

import { ContextualbarEmptyContent } from '../../../../../components/Contextualbar';
Expand Down Expand Up @@ -36,7 +37,21 @@ const MessageSearch = ({ searchText, globalSearch }: MessageSearchProps): ReactE
<Box display='flex' flexDirection='column' flexGrow={1} flexShrink={1} flexBasis={0}>
{messageSearchQuery.data && (
<>
{messageSearchQuery.data.length === 0 && <ContextualbarEmptyContent title={t('No_results_found')} />}
{messageSearchQuery.data.length === 0 && (
<Box is='section' aria-live='assertive' aria-atomic='true' tabindex={-1}
key={`no-results-${messageSearchQuery.data.length}`}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
aria-label={t('Search_Messages_Count', { count: messageSearchQuery.data.length })}
>
<ContextualbarEmptyContent title={t('No_results_found')} />
</Box>
)}

{messageSearchQuery.data.length > 0 && (
<VisuallyHidden role='status' aria-live='assertive' aria-atomic='true' aria-relevant='text' id='search-results-announcer'>
{t('Search_Messages_Count', { count: messageSearchQuery.data.length })}
</VisuallyHidden>
)}

{messageSearchQuery.data.length > 0 && (
<MessageListErrorBoundary>
<MessageListProvider>
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4645,6 +4645,10 @@
"Search_Installed_Apps": "Search installed apps",
"Search_Integrations": "Search Integrations",
"Search_Messages": "Search Messages",
"Search_Messages_Count": {
"one": "Found {{count}} single result",
"other": "Found {{count}} results"
},
"Search_Page_Size": "Page Size",
"Search_Premium_Apps": "Search Premium apps",
"Search_Private_Groups": "Search Private Groups",
Expand Down