Skip to content

fix: Pagination not working properly in UsersInRoleTable #37203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Oct 14, 2025
Merged

fix: Pagination not working properly in UsersInRoleTable #37203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee7f8ee
fix: pagination count
dougfabris Oct 10, 2025
a59805c
chore: changeset
dougfabris Oct 13, 2025
8a82b5a
Merge branch 'develop' into fix/usersInRolePagination
kodiakhq[bot] Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-tomatoes-try.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes an issue where pagination is not working properly in “users in role” table
2 changes: 1 addition & 1 deletion apps/meteor/client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const UsersInRoleTable = ({ rid, roleId, roleName, description }: UsersInRoleTab
divider
current={current}
itemsPerPage={itemsPerPage}
count={users.length || 0}
count={data.total || 0}
onSetItemsPerPage={onSetItemsPerPage}
onSetCurrent={onSetCurrent}
{...paginationProps}
Expand Down
Loading