Skip to content

fix: Client crash on missing proper attachments.fields #37147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Oct 16, 2025
Merged

fix: Client crash on missing proper attachments.fields #37147

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dd0a71
fix: client crash on invalid payload
yash-rajpal Oct 15, 2025
aa2a2ac
add changeset
yash-rajpal Oct 15, 2025
dae31ab
Merge branch 'develop' into fix/attachement-fields
yash-rajpal Oct 15, 2025
a1d7f16
Merge branch 'develop' into fix/attachement-fields
kodiakhq[bot] Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilled-pans-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes client crash on invalid message attachment fields payload.
8 changes: 6 additions & 2 deletions apps/meteor/client/components/message/content/attachments/DefaultAttachment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ const DefaultAttachment = (attachment: DefaultAttachmentProps): ReactElement =>

return {
Comment thread
yash-rajpal marked this conversation as resolved.
...rest,
title: <MarkdownText variant='inline' parseEmoji content={title.replace(/(.*)/g, (line: string) => `${line} `)} />,
value: <MarkdownText variant='inline' parseEmoji content={value.replace(/(.*)/g, (line: string) => `${line} `)} />,
title: title ? (
<MarkdownText variant='inline' parseEmoji content={title.replace(/(.*)/g, (line: string) => `${line} `)} />
) : null,
value: value ? (
<MarkdownText variant='inline' parseEmoji content={value.replace(/(.*)/g, (line: string) => `${line} `)} />
) : null,
};
})}
/>
Expand Down
Loading