Skip to content

feat(a11y): Missing FieldGroup legend in profile page #37119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 9 commits into from
Nov 13, 2025
Merged

feat(a11y): Missing FieldGroup legend in profile page #37119

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9d80181
Added a visually hidden legend
ergotse Oct 2, 2025
7a584f9
Merge branch 'develop' into 168-profile
dougfabris Nov 10, 2025
5f89a97
fix: lint
dougfabris Nov 10, 2025
3036f51
Merge branch 'develop' into 168-profile
dougfabris Nov 11, 2025
fa692b9
chore: remove `Box`
dougfabris Nov 11, 2025
04902d0
chore: changeset
dougfabris Nov 11, 2025
6cd5e6d
Merge branch 'develop' into 168-profile
dougfabris Nov 12, 2025
8af1591
Merge branch 'develop' into 168-profile
kodiakhq[bot] Nov 12, 2025
2a4d05a
Merge branch 'develop' into 168-profile
dougfabris Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/meteor/client/views/account/profile/AccountProfileForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
import UserStatusMenu from '../../../components/UserStatusMenu';
import UserAvatarEditor from '../../../components/avatar/UserAvatarEditor';
import { useUpdateAvatar } from '../../../hooks/useUpdateAvatar';
import { USER_STATUS_TEXT_MAX_LENGTH, BIO_TEXT_MAX_LENGTH } from '../../../lib/constants';

Check failure on line 37 in apps/meteor/client/views/account/profile/AccountProfileForm.tsx

View workflow job for this annotation

GitHub Actions / 🔎 Code Check / Code Lint 

There should be at least one empty line between import groups
import { VisuallyHidden } from 'react-aria';

Check failure on line 38 in apps/meteor/client/views/account/profile/AccountProfileForm.tsx

View workflow job for this annotation

GitHub Actions / 🔎 Code Check / Code Lint 

`react-aria` import should occur before import of `react-hook-form`

const AccountProfileForm = (props: AllHTMLAttributes<HTMLFormElement>): ReactElement => {
const t = useTranslation();
Expand Down Expand Up @@ -142,6 +143,9 @@
return (
<Box {...props} is='form' autoComplete='off' onSubmit={handleSubmit(handleSave)}>
<FieldGroup>
<VisuallyHidden>
<Box is='legend'>{t('Profile_details')}</Box>
</VisuallyHidden>
<Field>
<Controller
control={control}
Expand Down Expand Up @@ -240,7 +244,12 @@
<Controller
control={control}
name='statusText'
rules={{ maxLength: { value: USER_STATUS_TEXT_MAX_LENGTH, message: t('Max_length_is', USER_STATUS_TEXT_MAX_LENGTH) } }}
rules={{
maxLength: {
value: USER_STATUS_TEXT_MAX_LENGTH,
message: t('Max_length_is', USER_STATUS_TEXT_MAX_LENGTH),
},
}}
render={({ field }) => (
<TextInput
{...field}
Expand Down
Loading