Skip to content

chore(i18n): Readapt build scripts #36960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 20 commits into from
Oct 8, 2025
Merged

chore(i18n): Readapt build scripts #36960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
adfa563
Change manifest exports
tassoevan Sep 16, 2025
28b9992
Include .mts and .cts files in linting
tassoevan Sep 16, 2025
8eb4681
Convert scripts to TypeScript
tassoevan Sep 16, 2025
56a2fb8
Use tsx to run Mocha tests
tassoevan Sep 17, 2025
7b0b606
Make `@rocket.chat/jest-presets` a ESM package
tassoevan Sep 17, 2025
0c6eb46
Remove unnecessary `allowJs` directive on tsconfigs
tassoevan Sep 17, 2025
9e6c0df
Overhaul manifest
tassoevan Sep 20, 2025
9ac1d18
Change unit test
tassoevan Sep 22, 2025
5d82795
Move translation resource script
tassoevan Sep 23, 2025
1e3b063
Add tasks for handling plurals
tassoevan Sep 24, 2025
92f7037
Improve old placeholder format detection
tassoevan Sep 24, 2025
f89fa10
RRemove unused script
tassoevan Sep 25, 2025
16d6823
Add check for matching placeholders
tassoevan Sep 25, 2025
c72a827
Fix odd SAML translations
tassoevan Sep 25, 2025
1e775ef
Manage ummatched placeholders
tassoevan Sep 25, 2025
bbd6b06
Add task for positional parameters
tassoevan Sep 26, 2025
3a41a94
Move script to replace positional parameters
tassoevan Sep 26, 2025
d094738
Fix minor mistakes
tassoevan Sep 26, 2025
90e1c3e
Fix regexp matching
tassoevan Sep 26, 2025
7943027
Add type guards
tassoevan Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/.mocharc.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"reporter": "spec",
"extension": ["js", "ts", "tsx"],
"require": [
"ts-node/register",
"tsx",
"./tests/setup/chaiPlugins.ts"
],
Comment on lines 5 to 8
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Restore the tsx runtime registration

Swapping ts-node/register for bare tsx stops Mocha from installing any TS loader—the tsx package only exports helpers when required and does not self-register. As soon as Mocha loads ./tests/setup/chaiPlugins.ts (or any .ts spec), Node will try to execute raw TypeScript and blow up with syntax errors. Please require tsx/register (or call require('tsx').register() explicitly) so the tsx transpiler is actually wired in.

Apply this diff to fix the regression:

-		"tsx",
+		"tsx/register",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"require": [
"ts-node/register",
"tsx",
"./tests/setup/chaiPlugins.ts"
],
// apps/meteor/.mocharc.base.json
{
// …
"require": [
"tsx/register",
"./tests/setup/chaiPlugins.ts"
],
// …
}
🤖 Prompt for AI Agents 
In apps/meteor/.mocharc.base.json around lines 5 to 8, the "require" array
currently lists "tsx" which does not self-register a TS loader; replace it with
"tsx/register" (or call require('tsx').register() from a small bootstrap file)
so the tsx transpiler is actually wired before Mocha loads any .ts files; update
the array entry to "tsx/register" (or add a new require entry that points to a
tiny module that calls require('tsx').register() and then requires
./tests/setup/chaiPlugins.ts).

Copy link
Contributor Author

@tassoevan tassoevan Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this is false.

"watch-files": [
Expand Down
14 changes: 0 additions & 14 deletions apps/meteor/.mocharc.definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@

const base = require('./.mocharc.base.json');

/**
* Mocha will run `ts-node` without doing type checking to speed-up the tests. It should be fine as `npm run typecheck`
* covers test files too.
*/

Object.assign(
process.env,
{
TS_NODE_FILES: true,
TS_NODE_TRANSPILE_ONLY: true,
},
process.env,
);

module.exports = {
...base, // see https://github.com/mochajs/mocha/issues/3916
require: [...base.require],
Expand Down
14 changes: 0 additions & 14 deletions apps/meteor/.mocharc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@

const base = require('./.mocharc.base.json');

/**
* Mocha will run `ts-node` without doing type checking to speed-up the tests. It should be fine as `npm run typecheck`
* covers test files too.
*/

Object.assign(
process.env,
{
TS_NODE_FILES: true,
TS_NODE_TRANSPILE_ONLY: true,
},
process.env,
);

module.exports = {
...base, // see https://github.com/mochajs/mocha/issues/3916
exit: true,
Expand Down
140 changes: 0 additions & 140 deletions apps/meteor/.scripts/replaceTranslationSprintfParams.ts
View file
Open in desktop

This file was deleted.

Loading
Loading