Skip to content

chore!: Remove deprecated setReaction meteor method #36837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 2 commits into from
Sep 1, 2025
Merged

chore!: Remove deprecated setReaction meteor method #36837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff7fb11
chore!: Remove deprecated `setReaction` meteor method
MartinSchoeler Aug 29, 2025
4249add
Create honest-knives-cough.md
MartinSchoeler Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-knives-cough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": major
---

Removes the deprecated `setReaction` meteor method
29 changes: 1 addition & 28 deletions apps/meteor/app/reactions/server/setReaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Apps, AppEvents } from '@rocket.chat/apps';
import { api, Message } from '@rocket.chat/core-services';
import { Message } from '@rocket.chat/core-services';
import type { IMessage, IRoom, IUser } from '@rocket.chat/core-typings';
import type { ServerMethods } from '@rocket.chat/ddp-client';
import { Messages, EmojiCustom, Rooms, Users } from '@rocket.chat/models';
import { Meteor } from 'meteor/meteor';

Expand All @@ -11,7 +10,6 @@ import { canAccessRoomAsync } from '../../authorization/server';
import { hasPermissionAsync } from '../../authorization/server/functions/hasPermission';
import { emoji } from '../../emoji/server';
import { isTheLastMessage } from '../../lib/server/functions/isTheLastMessage';
import { methodDeprecationLogger } from '../../lib/server/lib/deprecationWarningLogger';
import { notifyOnMessageChange } from '../../lib/server/lib/notifyListener';

export const removeUserReaction = (message: IMessage, reaction: string, username: string) => {
Expand Down Expand Up @@ -159,28 +157,3 @@ declare module '@rocket.chat/ddp-client' {
setReaction(reaction: string, messageId: IMessage['_id'], shouldReact?: boolean): boolean | undefined;
}
}

Meteor.methods<ServerMethods>({
async setReaction(reaction, messageId, shouldReact) {
methodDeprecationLogger.method('setReaction', '8.0.0', '/v1/chat.react');

const uid = Meteor.userId();
if (!uid) {
throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'setReaction' });
}

try {
await executeSetReaction(uid, reaction, messageId, shouldReact);
} catch (e: any) {
if (e.error === 'error-not-allowed' && e.reason && e.details && e.details.rid) {
void api.broadcast('notify.ephemeralMessage', uid, e.details.rid, {
msg: e.reason,
});

return false;
}

throw e;
}
},
});
Loading