Skip to content

fix: moment js not loading some locales #36651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Aug 19, 2025
Merged

fix: moment js not loading some locales #36651

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8d5f69
fix: moment js not loading some locales
yash-rajpal Aug 6, 2025
41cefbb
add changeset
yash-rajpal Aug 7, 2025
311b89f
refactor
yash-rajpal Aug 19, 2025
6d8b1c8
fix async loop
yash-rajpal Aug 19, 2025
d3ac799
Merge branch 'develop' into fix/moment-locales
kodiakhq[bot] Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rare-fans-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes some locale loading issues for date-time formatting functionality.
16 changes: 12 additions & 4 deletions apps/meteor/server/lib/getMomentLocale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
import { Meteor } from 'meteor/meteor';

const mapLocaleToMomentLocale: Record<string, string> = {
ug: 'ug-cn',
zh: 'zh-cn',
};

export async function getMomentLocale(locale: string): Promise<string | undefined> {
Comment thread
yash-rajpal marked this conversation as resolved.
const localeLower = locale.toLowerCase();

try {
return Assets.getTextAsync(`moment-locales/${localeLower}.js`);
return await Assets.getTextAsync(`moment-locales/${localeLower}.js`);
} catch (error) {
try {
return Assets.getTextAsync(`moment-locales/${String(localeLower.split('-').shift())}.js`);
return await Assets.getTextAsync(`moment-locales/${String(localeLower.split('-').shift())}.js`);
} catch (error) {
throw new Meteor.Error('moment-locale-not-found', `Moment locale not found: ${locale}`);
try {
return await Assets.getTextAsync(`moment-locales/${mapLocaleToMomentLocale[localeLower]}.js`);
} catch (error) {
throw new Meteor.Error('moment-locale-not-found', `Moment locale not found: ${locale}`);
}
}
}
}
Loading