Skip to content

fix: prevent unexpected token errors from newer syntax in apps #36625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Aug 18, 2025
Merged

fix: prevent unexpected token errors from newer syntax in apps #36625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a487b4
Update accepted ecmaVersion on acorn
d-gubert Aug 5, 2025
2632207
Add changeset
d-gubert Aug 6, 2025
59ddf32
Update .changeset/late-toes-remain.md
d-gubert Aug 18, 2025
3b17e05
Merge branch 'develop' into fix/update-apps-ecmaVersion
kodiakhq[bot] Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/late-toes-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@rocket.chat/meteor': patch
'@rocket.chat/apps-engine': patch
---

Fixes an issue where app installation would fail if the app package contained JS syntax newer than 2017
3 changes: 2 additions & 1 deletion packages/apps-engine/deno-runtime/lib/ast/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ function fixAst(ast: Program): boolean {

export function fixBrokenSynchronousAPICalls(appSource: string): string {
const astRootNode = parse(appSource, {
ecmaVersion: 2017,
// Latest ecma version supported by this version of acorn.
ecmaVersion: "latest",
// Allow everything, we don't want to complain if code is badly written
// Also, since the code itself has been transpiled, the chance of getting
// shenanigans is lower
Expand Down
Loading