Skip to content

fix: Livechat widget connecting to localhost instead of actual site url #36332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 6 commits into from
Jul 7, 2025
Merged

fix: Livechat widget connecting to localhost instead of actual site url #36332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94febe0
livechat connecting to localhost instead of actual server url
KevLehman Jun 30, 2025
68f4646
Create late-donkeys-beg.md
KevLehman Jun 30, 2025
1b689c3
Merge branch 'develop' into fix/livechat-wrong-server-url
kodiakhq[bot] Jul 1, 2025
68f3b6f
Merge branch 'develop' into fix/livechat-wrong-server-url
KevLehman Jul 4, 2025
90432d4
test
KevLehman Jul 4, 2025
c436301
Merge branch 'develop' into fix/livechat-wrong-server-url
kodiakhq[bot] Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-donkeys-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes livechat widget attempting to connect to localhost instead of actual site url
4 changes: 2 additions & 2 deletions apps/meteor/app/livechat/server/livechat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { WebApp } from 'meteor/webapp';
import { settings } from '../../settings/server';
import { addServerUrlToIndex } from '../lib/Assets';

const indexHtmlWithServerURL = addServerUrlToIndex((await Assets.getTextAsync('livechat/index.html')) || '');
const indexHtmlWithServerURL = await Assets.getTextAsync('livechat/index.html');

function parseExtraAttributes(widgetData: string): string {
const liveChatAdditionalScripts = settings.get<string>('Livechat_AdditionalWidgetScripts');
Expand Down Expand Up @@ -66,6 +66,6 @@ WebApp.connectHandlers.use('/livechat', (req, res, next) => {
res.removeHeader('Content-Security-Policy');
}

res.write(memoizedParseExtraAttributes(indexHtmlWithServerURL));
res.write(memoizedParseExtraAttributes(addServerUrlToIndex(indexHtmlWithServerURL || '')));
res.end();
});
35 changes: 35 additions & 0 deletions apps/meteor/tests/unit/app/livechat/lib/assets.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { expect } from 'chai';
import { describe, it, before, after } from 'mocha';

import { addServerUrlToIndex } from '../../../../../app/livechat/lib/Assets';

describe('addServerUrlToIndex', () => {
before(() => {
(global as any).__meteor_runtime_config__ = { ROOT_URL: 'http://localhost:3000' };
});
after(() => {
delete (global as any).__meteor_runtime_config__;
});

it('should do nothing if "file" has no <body> tag', () => {
const file = addServerUrlToIndex('file');
expect(file).to.equal('file');
});
it('should replace <body> with an script tag containing the SERVER_URL inside', () => {
const file = addServerUrlToIndex('<html><body></body></html>');
expect(file).to.equal("<html><body><script> SERVER_URL = 'http://localhost:3000'; </script></body></html>");
});
it('should remove any trailing / from the SERVER_URL', () => {
(global as any).__meteor_runtime_config__ = { ROOT_URL: 'http://localhost:3000/' };
const file = addServerUrlToIndex('<html><body></body></html>');
expect(file).to.equal("<html><body><script> SERVER_URL = 'http://localhost:3000'; </script></body></html>");
});
it('should use the value from the global variable always', () => {
const file = addServerUrlToIndex('<html><body></body></html>');
expect(file).to.equal("<html><body><script> SERVER_URL = 'http://localhost:3000'; </script></body></html>");

(global as any).__meteor_runtime_config__ = { ROOT_URL: 'http://kodiak.rocket.chat/' };
const file2 = addServerUrlToIndex('<html><body></body></html>');
expect(file2).to.equal("<html><body><script> SERVER_URL = 'http://kodiak.rocket.chat'; </script></body></html>");
});
});
Loading