Skip to content

fix: VoIP widget mute action muting received audio instead of just microphone. #36229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Jun 20, 2025
Merged

fix: VoIP widget mute action muting received audio instead of just microphone. #36229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df55d21
Mute only sender tracks and stop triggering reinvite
gabriellsh Jun 16, 2025
994fb4b
create changeset
gabriellsh Jun 16, 2025
0ee5d55
Merge branch 'develop' into fix/voipMute
gabriellsh Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-tips-bake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/ui-voip": patch
---

Fixes VoIP widget mute action muting received audio instead of just microphone
33 changes: 4 additions & 29 deletions packages/ui-voip/src/lib/VoipClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,35 +288,10 @@ class VoipClient extends Emitter<VoipEvents> {
throw new Error('Peer connection closed.');
}

try {
const options: SessionInviteOptions = {
requestDelegate: {
onAccept: (): void => {
this.muted = mute;
this.toggleMediaStreamTracks('sender', !this.muted);
this.toggleMediaStreamTracks('receiver', !this.muted);
this.emit('stateChanged');
},
onReject: (): void => {
this.toggleMediaStreamTracks('sender', !this.muted);
this.toggleMediaStreamTracks('receiver', !this.muted);
this.emit('muteerror');
},
},
};

await this.session.invite(options);

this.toggleMediaStreamTracks('sender', !this.muted);
this.toggleMediaStreamTracks('receiver', !this.muted);
} catch (error) {
if (error instanceof RequestPendingError) {
console.error(`[${this.session?.id}] A mute request is already in progress.`);
}

this.emit('muteerror');
throw error;
}
const enableTracks = !mute;
this.toggleMediaStreamTracks('sender', enableTracks);
this.muted = mute;
this.emit('stateChanged');
};

public setHold = async (hold: boolean): Promise<void> => {
Expand Down
Loading