Skip to content

fix: Incoming VoIP calls playing "dial" sound when answered #36225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Jun 20, 2025
Merged

fix: Incoming VoIP calls playing "dial" sound when answered #36225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
931058e
only emit outgoing event for outgoing calls
gabriellsh Jun 16, 2025
2620742
Handle sound on provider instead
gabriellsh Jun 16, 2025
fc8250b
add cs
gabriellsh Jun 16, 2025
1eff686
Merge branch 'develop' into fix/voipRinging
kodiakhq[bot] Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strong-trains-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/ui-voip": patch
---

Fixes incoming VoIP calls playing "dial" sound when answered
7 changes: 6 additions & 1 deletion packages/ui-voip/src/providers/VoipProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ const VoipProvider = ({ children }: { children: ReactNode }) => {
};

const onOutgoingCallRinging = (): void => {
voipSounds.playDialer();
// VoipClient 'outgoingcall' event is emitted when the call is establishing
// and that event is also emitted when the call is accepted
// to avoid disrupting the VoipClient flow, we check if the call is outgoing here.
if (voipClient.isOutgoing()) {
voipSounds.playDialer();
}
};

const onIncomingCallRinging = (): void => {
Expand Down
Loading