Skip to content

fix: AJV schema for departmentId/agents endpoint missing name property #36154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 6 commits into from
Jun 9, 2025
+14 −3
Merged

fix: AJV schema for departmentId/agents endpoint missing name property #36154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53954e2
ajv schm missing a random prop
KevLehman Jun 4, 2025
3a1016d
Merge branch 'develop' into fix/ajv-issue
KevLehman Jun 5, 2025
04ad3f3
Create blue-books-wash.md
KevLehman Jun 5, 2025
82cebe7
Update blue-books-wash.md
KevLehman Jun 9, 2025
12f121e
Merge branch 'develop' into fix/ajv-issue
kodiakhq[bot] Jun 9, 2025
5b63624
Merge branch 'develop' into fix/ajv-issue
kodiakhq[bot] Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/blue-books-wash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@rocket.chat/meteor": patch
"@rocket.chat/rest-typings": patch
---

Fixes an issue that prevented the action of saving an agent when editing a department to work.
3 changes: 2 additions & 1 deletion apps/meteor/tests/end-to-end/api/livechat/10-departments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,8 @@ import { IS_EE } from '../../../e2e/config/constants';
const res = await request
.post(api(`livechat/department/${dep._id}/agents`))
.set(credentials)
.send({ upsert: [{ agentId: agent._id, username: agent.username }], remove: [] })
// UI sends agent name as well. API doens't use it, but keeping here for avoid Breaking Changes
.send({ upsert: [{ agentId: agent._id, username: agent.username, name: agent.name }], remove: [] })
.expect(200);
expect(res.body).to.have.property('success', true);
await deleteDepartment(dep._id);
Expand Down
8 changes: 6 additions & 2 deletions packages/rest-typings/src/v1/omnichannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ export const isLivechatDepartmentDepartmentIdAgentsGETProps = ajv.compile<Livech
);

type LivechatDepartmentDepartmentIdAgentsPOST = {
upsert: { agentId: string; username: string; count?: number; order?: number }[];
remove: { agentId: string; username: string; count?: number; order?: number }[];
upsert: { agentId: string; username: string; name?: string; count?: number; order?: number }[];
remove: { agentId: string; username: string; name?: string; count?: number; order?: number }[];
};

const LivechatDepartmentDepartmentIdAgentsPOSTSchema = {
Expand All @@ -183,6 +183,7 @@ const LivechatDepartmentDepartmentIdAgentsPOSTSchema = {
username: {
type: 'string',
},
name: { type: 'string' },
count: {
type: 'number',
},
Expand All @@ -205,6 +206,9 @@ const LivechatDepartmentDepartmentIdAgentsPOSTSchema = {
username: {
type: 'string',
},
name: {
type: 'string',
},
count: {
type: 'number',
},
Expand Down
Loading