fix: Remove `Change to Default` button suggestion in login page #36062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

kodiakhq merged 4 commits into develop from fix/change-default-button

May 27, 2025

+23 −7

.changeset/breezy-ravens-design.md

-Original file line number
+Diff line change
@@ -0,0 +1,6 @@
+    ---
+    "@rocket.chat/meteor": patch
+    "@rocket.chat/web-ui-registration": patch
+    ---
+    Removes the `Change to Default` language button from the login page

apps/meteor/tests/e2e/login.spec.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -59,6 +59,9 @@ test.describe.parallel('Login', () => { @@
     	test('Should correctly display switch language button', async ({ page, api }) => {
     		expect((await setSettingValueById(api, 'Language', 'pt-BR')).status()).toBe(200);
+    		const buttonDefault = page.getByRole('button', { name: 'Change to Default' });
+    		await expect(buttonDefault).not.toBeVisible();
     		const button = page.getByRole('button', { name: 'Alterar para português (Brasil)' });
     		await button.click();
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -60,13 +60,20 @@ const LoginSwitchLanguageFooter = ({ @@
     	return (
     		<HorizontalWizardLayoutCaption>
-    			{suggestions.map((suggestion) => (
-    				<Button secondary small mie={8} key={suggestion.key} onClick={handleSwitchLanguageClick(suggestion)}>
-    					<Trans i18nKey='registration.component.switchLanguage' tOptions={{ lng: suggestion.key }} values={{ name: suggestion.ogName }}>
-    						Change to <strong>{suggestion.ogName}</strong>
-    					</Trans>
-    				</Button>
-    			))}
+    			{suggestions.map((suggestion) => {
+    				// If suggestion is "Default", skip it
+    				if (!suggestion.key) {
+    					return;
+    				}
+    				return (
+    					<Button secondary small mie={8} key={suggestion.key} onClick={handleSwitchLanguageClick(suggestion)}>
+    						<Trans i18nKey='registration.component.switchLanguage' tOptions={{ lng: suggestion.key }} values={{ name: suggestion.ogName }}>
+    							Change to <strong>{suggestion.ogName}</strong>
+    						</Trans>
+    					</Button>
+    				);
+    			})}
     		</HorizontalWizardLayoutCaption>
     	);
     };
@@ Expand Down @@

Provide feedback