Skip to content

chore: fix race condition on LocalBroker service's dependencies #35997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Jul 30, 2025
Merged

chore: fix race condition on LocalBroker service's dependencies #35997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core-services/src/LocalBroker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ export class LocalBroker implements IBroker {
* Registers services to be started. We're assuming that each service will only have one level of dependencies.
*/
private registerPendingServices(services: string[] = []): void {
for (const service of services) {
this.pendingServices.add(service);
}
services
.filter((e) => !this.services.has(e) || !this.services.get(e)?.isStarted)
.forEach((service) => this.pendingServices.add(service));
}

/**
Expand Down
Loading