Skip to content

regression: Passing servedBy instead of servedBy.id to findOne call when converting a room from app #35935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
May 6, 2025
Merged

regression: Passing servedBy instead of servedBy.id to findOne call when converting a room from app #35935

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a86cedc
fix regression
KevLehman May 6, 2025
72554e8
Update rooms.js
KevLehman May 6, 2025
f61adf6
cr
KevLehman May 6, 2025
96aa2e8
Update apps/meteor/app/apps/server/converters/rooms.js
KevLehman May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/app/apps/server/converters/rooms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class AppRoomsConverter {

const departmentId = await this.__getDepartment(room);

const servedBy = await this.__getUserIdAndUsername(room.servedBy);
const servedBy = await this.__getUserIdAndUsername(room?.servedBy?.id);
Comment thread
KevLehman marked this conversation as resolved.
Outdated

const closedBy = await this.__getRoomCloser(room, v);

Expand Down