Skip to content

test(flaky): ensure agent info is saved before reopening tab #35910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Apr 30, 2025
Merged

test(flaky): ensure agent info is saved before reopening tab #35910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d92db08
fix: ensure agent info is saved before opening tab again
ggazzo Apr 30, 2025
922e625
test: expect save password state on encrypted room
ggazzo Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/meteor/tests/e2e/e2e-encryption.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,8 @@ test.describe.serial('e2ee room setup', () => {

await page.goto('/home');

await page.waitForSelector('.main-content');

await expect(poHomeChannel.bannerSaveEncryptionPassword).toBeVisible();

const channelName = faker.string.uuid();
Expand Down
13 changes: 13 additions & 0 deletions apps/meteor/tests/e2e/omnichannel/omnichannel-agents.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,21 @@ test.describe.serial('OC - Manage Agents', () => {

await poOmnichannelAgents.btnEdit.click();
await poOmnichannelAgents.selectDepartment(department.data.name);
const reg = new RegExp(`/api/v1/method.call/${encodeURIComponent('livechat:saveAgentInfo')}`);
const response = page.waitForResponse(reg);
await poOmnichannelAgents.btnSave.click();

/**
* between saving and opening the agent info again it is necessary to
* wait for the agent to be saved, since after successfully saving
* the contextual bar is closed
* otherwise content will be closed even if the current one is not the editing one
*/

await response;

await expect(poOmnichannelAgents.editCtxBar).not.toBeVisible();

await test.step('expect the selected department is visible', async () => {
await poOmnichannelAgents.findRowByUsername('user1').click();

Expand Down
Loading