Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

RocketChat / Rocket.Chat Public

Notifications You must be signed in to change notification settings
Fork 13.1k
Star 44.4k

Code
Issues 2.6k
Pull requests 959
Discussions
Actions
Projects 2
Wiki
Security 1
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

refactor: dont use `useEffect` anymore to control thread scroll#35818

Merged

ggazzo merged 18 commits intodevelopRocketChat/Rocket.Chat:developfrom

fix/thread-jumpRocketChat/Rocket.Chat:fix/thread-jumpCopy head branch name to clipboard

Apr 16, 2025

Conversation Commits18 (18)Checks Files changed

Merged

refactor: dont use `useEffect` anymore to control thread scroll#35818
ggazzo merged 18 commits intodevelopfrom
fix/thread-jump

Commits

Commits on Apr 16, 2025

dont use effect anymore to control thread scroll
ggazzo
committed
refactor: simplify scrolling logic in useLegacyThreadMessageListScrolling by removing onScroll
ggazzo
committed
refactor: invert ref logic dependency list x items to scroll
ggazzo
committed
Apply suggestions from code review
ggazzo
authored
refactor: change innerBoxRef type from HTMLDivElement | null to HTMLElement in RoomBody components
ggazzo
committed
Merge branch 'fix/thread-jump' of github.com:RocketChat/Rocket.Chat into fix/thread-jump
ggazzo
committed
dont jump to bottom if there is message to jump
ggazzo
committed
no need to change the scrolltop after rerender
ggazzo
committed
restore should not apply any fallback
ggazzo
committed
replace old code from useLegacyThreadMessageListScrolling with useListIsAtBottom
ggazzo
committed
fix ThreadMessageList references
ggazzo
committed
unused variable
ggazzo
committed
Merge branch 'develop' into fix/thread-jump
ggazzo
authored
test: change unit test
ggazzo
committed
Merge branch 'fix/thread-jump' of github.com:RocketChat/Rocket.Chat into fix/thread-jump
ggazzo
committed
improve test for delayed cases
ggazzo
committed
Merge branch 'develop' into fix/thread-jump
ggazzo
authored
review
ggazzo
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.