Skip to content

fix: typo on app setting save #35733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 6 commits into from
Apr 9, 2025
Merged

fix: typo on app setting save #35733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
275253c
fix: type on app setting save
Gustrb Apr 8, 2025
cb28d82
Update packages/i18n/src/locales/en.i18n.json
Gustrb Apr 8, 2025
e089620
Create witty-foxes-thank.md
Gustrb Apr 8, 2025
1517dc7
Update .changeset/witty-foxes-thank.md
Gustrb Apr 8, 2025
a1d88aa
Merge branch 'develop' into fix/typo-on-app-save
kodiakhq[bot] Apr 8, 2025
95234d4
Merge branch 'develop' into fix/typo-on-app-save
kodiakhq[bot] Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/witty-foxes-thank.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@rocket.chat/meteor": patch
"@rocket.chat/i18n": patch
---

Fixes a typo in the app update success toast
2 changes: 1 addition & 1 deletion apps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const AppDetailsPage = ({ id }: AppDetailsPageProps): ReactElement => {
})),
);
reset(data);
dispatchToastMessage({ type: 'success', message: `${name} settings saved succesfully` });
dispatchToastMessage({ type: 'success', message: t('App_Settings_Saved_Successfully', { appName: name }) });
} catch (e: any) {
handleAPIError(e);
}
Expand Down
1 change: 1 addition & 0 deletions packages/i18n/src/locales/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@
"api-bypass-rate-limit_description": "Permission to call api without rate limitation",
"APIs": "APIs",
"App_Info": "App Info",
"App_Settings_Saved_Successfully": "{{appName}} saved successfully",
"Apps_context_enterprise": "Enterprise",
"App_has_been_disabled_addon_message_one": "The app {{appNames}} has been disabled because of an invalid add-on. A valid add-on subscription is required to re-enable it",
"App_has_been_disabled_addon_message_other": "The apps {{appNames}} have been disabled because of invalid add-ons. A valid add-on subscription is required to re-enable them",
Expand Down
Loading