Skip to content

fix: button to enable app not being displayed when app is migrated #35415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 3 commits into from
Mar 20, 2025
Merged

fix: button to enable app not being displayed when app is migrated #35415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f915f0
Display "Enable" button if the app is migrated
d-gubert Mar 6, 2025
ad2de53
Add changeset
d-gubert Mar 6, 2025
44267a0
Merge branch 'develop' into fix/migrated-app-enable
kodiakhq[bot] Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-crabs-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes an issue that prevents the Enable button from being displayed on some migrated apps
10 changes: 8 additions & 2 deletions apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,14 @@ export const useAppMenu = (app: App, isAppDetailsPage: boolean) => {
},
];

const isEnterpriseOrNot = (app.isEnterpriseOnly && isEnterpriseLicense) || !app.isEnterpriseOnly;
const isPossibleToEnableApp = app.installed && isAdminUser && !isAppEnabled && isEnterpriseOrNot;
const isPossibleToEnableApp =
app.installed &&
isAdminUser &&
!isAppEnabled &&
// If the app is migrated, it can be enabled regardless of other validations
// If not, and the app isEnterpriseOnly, we need to check the workspace's license
(app.migrated || !app.isEnterpriseOnly || isEnterpriseLicense);

const doesItReachedTheLimit =
!app.migrated &&
!appCountQuery?.data?.hasUnlimitedApps &&
Expand Down
Loading