-
Notifications
You must be signed in to change notification settings - Fork 13.8k
fix: Save button remains in loading state after saving app settings #35394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 26 commits into
RocketChat:develop
from
sushen123:fix/save-button-loading-state
Mar 26, 2025
Merged
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4c41d8d
fix: Save button remains in loading state after saving app settings
sushen123 503b6f7
Add changeset for save button loading state fix
sushen123 ff32d91
Update changeset for save button
sushen123 9be6db7
fix: Hide footer after saving app settings
sushen123 b46f1d8
Add Unit test for AppDetailsPage.tsx
sushen123 2a8368e
Merge branch 'develop' into fix/save-button-loading-state
sushen123 478f114
tests
abhinavkrin b0990d0
Merge branch 'develop' into fix/save-button-loading-state
scuciatto 731ffad
Merge branch 'develop' into fix/save-button-loading-state
d-gubert e403b1a
Merge branch 'develop' into fix/save-button-loading-state
scuciatto 07276ba
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] e89d573
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] 08681f4
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] 2046323
Merge branch 'develop' into fix/save-button-loading-state
d-gubert 24e8f75
Merge branch 'develop' into fix/save-button-loading-state
abhinavkrin d9436e0
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] 65efa6d
Merge branch 'develop' into fix/save-button-loading-state
abhinavkrin 1db7ad8
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] 6b7e6e1
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] dc30baf
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] c3a7441
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] 7a67296
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] cac46b3
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] a09d078
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] de922b4
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] ef85018
Merge branch 'develop' into fix/save-button-loading-state
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@rocket.chat/meteor': patch | ||
| --- | ||
|
|
||
| Fixes the save button loading state in the app settings page. The button now exits the loading state after settings are successfully saved. This resolves an issue where the button remained in a loading state indefinitely due to incorrect dependency on the `isSubmitted` state from `react-hook-form`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.