Skip to content

regression: not allowing apps with default permissions to read settings #35388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Mar 3, 2025
Merged

regression: not allowing apps with default permissions to read settings #35388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d03dd2c
regression: not allowing apps with default permissions to read settings
Gustrb Mar 3, 2025
f688543
chore: better comment
Gustrb Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/meteor/app/apps/server/bridges/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,18 @@ export class AppSettingBridge extends ServerSettingBridge {
}

const { permissions } = app.getInfo();

// If the app does not have any permissions we must assume it has a set of default permissions
// so, for being cautious, we will not allow it to read all settings.
// If one desires to read a hidden setting it must ask explicitly for it.
if (!permissions) {
this.orch.debugLog(`The app ${appId} has no configured permissions.`);
return null;
const setting = await Settings.findOneNotHiddenById(id);
if (!setting) {
this.orch.debugLog(`The setting ${id} is not found.`);
return null;
}

return this.orch.getConverters()?.get('settings').convertToApp(setting);
}

const readSettingsPermission = permissions.find((perm) => perm.name === 'server-setting.read');
Expand Down
Loading