-
Notifications
You must be signed in to change notification settings - Fork 13.7k
fix(apps): room converter errors out when converting livechat room closed by the visitor #35107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
183af50
Fix room converter when closer is visitor
d-gubert d6d053c
Merge remote-tracking branch 'origin/develop' into fix/apps-room-conv…
d-gubert aeff00b
Add changeset
d-gubert e069b0a
Update .changeset/popular-mugs-try.md
KevLehman e2222c8
Merge branch 'develop' into fix/apps-room-converter
d-gubert 8d111f4
Merge branch 'develop' into fix/apps-room-converter
d-gubert c64a581
Merge branch 'develop' into fix/apps-room-converter
d-gubert ebcc1bb
Merge branch 'develop' into fix/apps-room-converter
d-gubert 090b598
Merge branch 'develop' into fix/apps-room-converter
d-gubert d5f4500
Merge branch 'develop' into fix/apps-room-converter
d-gubert e3ff00b
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] 58ccfa4
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] 986aeca
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] 7ff8049
Merge branch 'develop' into fix/apps-room-converter
julio-rocketchat 632994a
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] 725c4e1
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] 9116dd6
Merge branch 'develop' into fix/apps-room-converter
d-gubert 9752701
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] cca19cd
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] 6eb28e9
Merge branch 'develop' into fix/apps-room-converter
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@rocket.chat/meteor': patch | ||
| --- | ||
|
|
||
| Fix an issue where the room converter would throw if the room was an omnichannel room that had been closed by the visitor | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.