fix: voip call history doesn't always log the correct call information #35006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

kodiakhq merged 30 commits into develop from fix/voip-log-parser

Jul 2, 2025

.changeset/shy-colts-appear.md

-Original file line number
+Diff line change
@@ -0,0 +1,11 @@
+    ---
+    '@rocket.chat/model-typings': patch
+    '@rocket.chat/core-typings': patch
+    '@rocket.chat/freeswitch': patch
+    '@rocket.chat/ui-voip': patch
+    '@rocket.chat/models': patch
+    '@rocket.chat/tools': patch
+    '@rocket.chat/meteor': patch
+    ---
+    Fixes the parsing of FreeSwitch events to properly generate a history of calls on Rocket.Chat

apps/meteor/app/statistics/server/lib/getVoIPStatistics.ts

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,7 +1,7 @@
  
    import { log } from 'console';

    import type { IStats, IVoIPPeriodStats } from '@rocket.chat/core-typings';

    import { FreeSwitchCall } from '@rocket.chat/models';

    import { FreeSwitchChannel } from '@rocket.chat/models';

    import { MongoInternals } from 'meteor/mongo';

    import { readSecondaryPreferred } from '../../../../server/database/readSecondaryPreferred';

    @@ -30,35 +30,37 @@ async function getVoIPStatisticsForPeriod(days?: number): Promise<IVoIPPeriodSta
  
    	const statistics: IVoIPPeriodStats = {};

    	promises.push(

    		FreeSwitchCall.countCallsByDirection('internal', minDate, options).then((count) => {

    		FreeSwitchChannel.countChannelsByKind('internal', minDate, options).then((count) => {

    			statistics.internalCalls = count;

    		}),

    	);

    	promises.push(

    		FreeSwitchCall.countCallsByDirection('external_inbound', minDate, options).then((count) => {

    		FreeSwitchChannel.countChannelsByKindAndDirection('external', 'inbound', minDate, options).then((count) => {

    			statistics.externalInboundCalls = count;

    		}),

    	);

    	promises.push(

    		FreeSwitchCall.countCallsByDirection('external_outbound', minDate, options).then((count) => {

    		FreeSwitchChannel.countChannelsByKindAndDirection('external', 'outbound', minDate, options).then((count) => {

    			statistics.externalOutboundCalls = count;

    		}),

    	);

    	promises.push(

    		FreeSwitchCall.sumCallsDuration(minDate, options).then((callsDuration) => {

    		FreeSwitchChannel.sumChannelsDurationByKind('internal', minDate, options).then((callsDuration) => {

    			statistics.callsDuration = callsDuration;

    		}),

    	);

    	promises.push(

    		FreeSwitchCall.countCallsBySuccessState(true, minDate, options).then((count) => {

    		FreeSwitchChannel.countChannelsByKindAndSuccessState('internal', true, minDate, options).then((count) => {

    			statistics.successfulCalls = count;

    		}),

    	);

    	promises.push(

    		FreeSwitchCall.countCallsBySuccessState(false, minDate, options).then((count) => {

    		FreeSwitchChannel.countChannelsByKindAndSuccessState('internal', false, minDate, options).then((count) => {

    			statistics.failedCalls = count;

    		}),

    	);

apps/meteor/client/hooks/useVoipClient.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -85,6 +85,8 @@ export const useVoipClient = (): UseVoipClientResult => { @@
     							iceServers,
     							connectionRetryCount: Number(voipRetryCount),
     							enableKeepAliveUsingOptionsForUnstableNetworks: Boolean(enableKeepAlive),
+    							userId: uid || '',
+    							siteUrl: '',
     						};
     						client = await (isEE ? EEVoipClient.create(config) : VoIPUser.create(config));
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: voip call history doesn't always log the correct call information #35006

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!