Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps-engine reliability fixes #34906

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: Apps-engine reliability fixes #34906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Adds simple app subprocess metrics report
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Attempts to restart an app subprocess if the spawn command fails
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Fixes an issue while collecting the error message from a failed restart attempt of an app subprocess
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Prevents app:getStatus requests from timing out in some cases
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Fixes an error where the engine would not retry a subprocess restart if the last attempt failed
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Fixes error propagation when trying to get the status of apps in some cases
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Fixes wrong data being reported to total failed apps metrics and statistics
38 changes: 38 additions & 0 deletions .changeset/silent-numbers-love8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
'@rocket.chat/omnichannel-services': patch
'rocketchat-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/stream-hub-service': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/account-service': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/core-services': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/models': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/meteor': patch
---

Fixes an issue that prevented the apps-engine from reestablishing communications with subprocesses in some cases
2 changes: 1 addition & 1 deletion apps/meteor/ee/server/services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "Rocket.Chat",
"license": "MIT",
"dependencies": {
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/core-services": "workspace:^",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/emitter": "~0.31.25",
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
"@rocket.chat/agenda": "workspace:^",
"@rocket.chat/api-client": "workspace:^",
"@rocket.chat/apps": "workspace:^",
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/base64": "workspace:^",
"@rocket.chat/cas-validate": "workspace:^",
"@rocket.chat/core-services": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion ee/apps/ddp-streamer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"author": "Rocket.Chat",
"dependencies": {
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/core-services": "workspace:^",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/emitter": "~0.31.25",
Expand Down
2 changes: 1 addition & 1 deletion ee/packages/presence/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"@babel/core": "~7.22.20",
"@babel/preset-env": "~7.22.20",
"@babel/preset-typescript": "~7.22.15",
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/eslint-config": "workspace:^",
"@rocket.chat/rest-typings": "workspace:^",
"@types/node": "^14.18.63",
Expand Down
2 changes: 1 addition & 1 deletion packages/apps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"/dist"
],
"dependencies": {
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/model-typings": "workspace:^"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core-services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"extends": "../../package.json"
},
"dependencies": {
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/icons": "^0.36.0",
"@rocket.chat/message-parser": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion packages/core-typings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"/dist"
],
"dependencies": {
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/icons": "^0.36.0",
"@rocket.chat/message-parser": "workspace:^",
"@rocket.chat/ui-kit": "workspace:~",
Expand Down
2 changes: 1 addition & 1 deletion packages/fuselage-ui-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"@babel/preset-env": "~7.22.20",
"@babel/preset-react": "~7.22.15",
"@babel/preset-typescript": "~7.22.15",
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/eslint-config": "workspace:^",
"@rocket.chat/fuselage": "^0.54.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/rest-typings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"/dist"
],
"dependencies": {
"@rocket.chat/apps-engine": "1.43.4",
"@rocket.chat/apps-engine": "1.43.5",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/message-parser": "workspace:^",
"@rocket.chat/ui-kit": "workspace:~",
Expand Down
Loading
Loading