Allow scrolling user status sidebar when screen height is too small #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
without stylizing the scrollbar it looks ugly on non-mac systems:
and with "overflow: scroll" it is always visible even if not needed:
|
|
I fixed the above styling issues. Thanks @captchadex and @sampaiodiego |
|
Without stylizing is used default browser style scrollbar (people who use this browser are already used with this style). I think overflow as "scroll" (always, even is not using) is a layout/design bug. It's fix the #343 , but i don't think it's correct fix. That probably occurs because the container don't know his height, so you can't scroll propertly. Btw, in Firefox 39 @ Win 8.1 overflow auto works even with small screen. |
HappyTobi
pushed a commit
to HappyTobi/Rocket.Chat
that referenced
this pull request
Jul 10, 2018
Stop redirect when dragging image/url into window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the bug described in #343