refactor: Remove settings dependency on startup

apps/meteor/app/assets/server/assets.ts

@@ -396,8 +396,6 @@ void (async () => {
 	}
 })();
 
-settings.watchByRegex(/^Assets_/, (key, value) => RocketChatAssets.processAsset(key, value));
-
 Meteor.startup(() => {
 	setTimeout(() => {
 		process.emit('message', {

apps/meteor/app/cors/server/cors.ts

@@ -16,21 +16,17 @@ type NextFunction = (err?: any) => void;
 
 const logger = new Logger('CORS');
 
-let templatePromise: Promise<void> | void;
-
 declare module 'meteor/webapp' {
 	// eslint-disable-next-line @typescript-eslint/no-namespace
 	namespace WebApp {
 		function setInlineScriptsAllowed(allowed: boolean): Promise<void>;
 	}
 }
 
-settings.watch<boolean>(
-	'Enable_CSP',
-	Meteor.bindEnvironment(async (enabled) => {
-		templatePromise = WebAppInternals.setInlineScriptsAllowed(!enabled);
-	}),
-);
+let templatePromise: Promise<void> | void;
+export async function setInlineScriptsAllowed(allowed: boolean): Promise<void> {
+	templatePromise = WebAppInternals.setInlineScriptsAllowed(allowed);
+}
 
 WebApp.rawConnectHandlers.use(async (_req: http.IncomingMessage, res: http.ServerResponse, next: NextFunction) => {
 	if (templatePromise) {
@@ -109,9 +105,9 @@ declare module 'meteor/webapp' {
 }
 
 let cachingVersion = '';
-settings.watch<string>('Troubleshoot_Force_Caching_Version', (value) => {
-	cachingVersion = String(value).trim();
-});
+export function setCachingVersion(value: string): void {
+	cachingVersion = value.trim();
+}
 
 // @ts-expect-error - accessing internal property of webapp
 WebAppInternals.staticFilesMiddleware = function (

apps/meteor/app/federation/server/startup/index.ts

@@ -1,3 +1,2 @@
 import './generateKeys';
-import './settings';
 import './registerCallbacks';

apps/meteor/app/irc/server/index.ts

@@ -1,2 +1 @@
-import './irc';
 import './methods/resetIrcConnection';

apps/meteor/app/lib/server/lib/index.ts

@@ -9,7 +9,6 @@ import './notifyUsersOnMessage';
 import './meteorFixes';
 
 export { sendNotification } from './sendNotificationsOnMessage';
-export { hostname } from '../startup/settingsOnLoadSiteUrl';
 export { passwordPolicy } from './passwordPolicy';
 export { validateEmailDomain } from './validateEmailDomain';
 export { RateLimiterClass as RateLimiter } from './RateLimiter';

apps/meteor/app/lib/server/startup/index.ts

@@ -1,5 +1,2 @@
 import './rateLimiter';
 import './robots';
-import './settingsOnLoadCdnPrefix';
-import './settingsOnLoadDirectReply';
-import './settingsOnLoadSMTP';

apps/meteor/server/configuration/cas.ts

@@ -3,12 +3,12 @@ import debounce from 'lodash.debounce';
 import { RoutePolicy } from 'meteor/routepolicy';
 import { WebApp } from 'meteor/webapp';
 
-import { settings } from '../../app/settings/server/cached';
+import type { ICachedSettings } from '../../app/settings/server/CachedSettings';
 import { loginHandlerCAS } from '../lib/cas/loginHandler';
 import { middlewareCAS } from '../lib/cas/middleware';
 import { updateCasServices } from '../lib/cas/updateCasService';
 
-export async function configureCAS() {
+export async function configureCAS(settings: ICachedSettings) {
 	const _updateCasServices = debounce(updateCasServices, 2000);
 
 	settings.watchByRegex(/^CAS_.+/, async () => {

apps/meteor/server/configuration/configureAssets.ts

@@ -0,0 +1,6 @@
+import { RocketChatAssets } from '../../app/assets/server';
+import type { ICachedSettings } from '../../app/settings/server/CachedSettings';
+
+export async function configureAssets(settings: ICachedSettings): Promise<void> {
+	settings.watchByRegex(/^Assets_/, (key, value) => RocketChatAssets.processAsset(key, value));
+}

apps/meteor/server/configuration/configureBoilerplate.ts

@@ -0,0 +1,35 @@
+import { Meteor } from 'meteor/meteor';
+import { WebAppInternals } from 'meteor/webapp';
+
+import type { ICachedSettings } from '../../app/settings/server/CachedSettings';
+
+export function configureBoilerplate(settings: ICachedSettings): void {
+	settings.watch<string>(
+		'Site_Url',
+		// Needed as WebAppInternals.generateBoilerplate needs to be called in a fiber
+		Meteor.bindEnvironment((value) => {
+			if (value == null || value.trim() === '') {
+				return;
+			}
+			let host = value.replace(/\/$/, '');
+			// let prefix = '';
+			const match = value.match(/([^\/]+\/{2}[^\/]+)(\/.+)/);
+			if (match != null) {
+				host = match[1];
+				// prefix = match[2].replace(/\/$/, '');
+			}
+			(global as any).__meteor_runtime_config__.ROOT_URL = value;
+
+			if (Meteor.absoluteUrl.defaultOptions?.rootUrl) {
+				Meteor.absoluteUrl.defaultOptions.rootUrl = value;
+			}
+
+			// hostname = host.replace(/^https?:\/\//, '');
+			process.env.MOBILE_ROOT_URL = host;
+			process.env.MOBILE_DDP_URL = host;
+			if (typeof WebAppInternals !== 'undefined' && WebAppInternals.generateBoilerplate) {
+				return WebAppInternals.generateBoilerplate();
+			}
+		}),
+	);
+}

apps/meteor/server/configuration/configureCDN.ts

@@ -0,0 +1,32 @@
+import { WebAppInternals } from 'meteor/webapp';
+
+import type { ICachedSettings } from '../../app/settings/server/CachedSettings';
+
+export async function configureCDN(settings: ICachedSettings): Promise<void> {
+	settings.change<string>('CDN_PREFIX', (value) => {
+		const useForAll = settings.get('CDN_PREFIX_ALL');
+		if (value && useForAll) {
+			WebAppInternals.setBundledJsCssPrefix(value);
+		}
+	});
+
+	settings.change<string>('CDN_JSCSS_PREFIX', (value) => {
+		const useForAll = settings.get('CDN_PREFIX_ALL');
+		if (value && typeof value === 'string' && value.trim() && !useForAll) {
+			WebAppInternals.setBundledJsCssPrefix(value);
+		}
+	});
+
+	const cdnValue = settings.get('CDN_PREFIX');
+	const useForAll = settings.get('CDN_PREFIX_ALL');
+	const cdnJsCss = settings.get('CDN_JSCSS_PREFIX');
+	if (cdnValue && typeof cdnValue === 'string' && cdnValue.trim()) {
+		if (useForAll) {
+			WebAppInternals.setBundledJsCssPrefix(cdnValue);
+			return;
+		}
+		if (cdnJsCss && typeof cdnJsCss === 'string' && cdnJsCss.trim()) {
+			WebAppInternals.setBundledJsCssPrefix(cdnJsCss);
+		}
+	}
+}

apps/meteor/server/configuration/configureCORS.ts

@@ -0,0 +1,11 @@
+import { setCachingVersion, setInlineScriptsAllowed } from '../../app/cors/server/cors';
+import type { ICachedSettings } from '../../app/settings/server/CachedSettings';
+
+export async function configureCORS(settings: ICachedSettings): Promise<void> {
+	settings.watch<boolean>('Enable_CSP', async (enabled) => {
+		await setInlineScriptsAllowed(!enabled);
+	});
+	settings.watch<string>('Troubleshoot_Force_Caching_Version', (value) => {
+		setCachingVersion(value);
+	});
+}