Skip to content

fix(messages): support multi-parameter sorting for IM/DM messages #34009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MahmoudMowiena wants to merge 2 commits into from
Closed

fix(messages): support multi-parameter sorting for IM/DM messages #34009

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df5ed1d
fix(messages): support multi-parameter sorting for IM/DM messages
MahmoudMowiena Nov 20, 2024
0a96cc4
A default sorting parameter is provided in case no sorting parameter …
MahmoudMowiena Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/meteor/app/api/server/v1/im.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,9 @@ API.v1.addRoute(
...parseIds(starredIds, 'starred._id'),
...(pinned && pinned.toLowerCase() === 'true' ? { pinned: true } : {}),
};
const sortObj = { ts: sort?.ts ?? -1 };

const { cursor, totalCount } = Messages.findPaginated(ourQuery, {
sort: sortObj,
sort: sort,
Comment thread
MahmoudMowiena marked this conversation as resolved.
Outdated
skip: offset,
limit: count,
...(fields && { projection: fields }),
Expand Down