Add settings for Piwik Analytics, for #233 #3299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this is a very basic implementation and only tracks the first page view. Later implementations might extend this further. Couldn't exactly test locally for some reason, so I am committing this to test via the requested deployment.
|
@RocketChat/core this is ready to be merged, I verified it. Next integration level will contain event tracking statistics with piwik, including but not limited tracking channel creations, deletions, archiving, and sending them to the piwki. |
|
LGTM |
1 similar comment
|
LGTM |
…e generated automatically
|
Closing in favor of a new pull request I will be opening in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #233
Right now this is a very basic implementation and only tracks the first page view. Later implementations might extend this further.
Couldn't exactly test locally for some reason, so I am committing this to test via the requested deployment.