Skip to content

fix: client ignoring offline presence updates #31833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 2 commits into from
Feb 28, 2024
Merged

fix: client ignoring offline presence updates #31833

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4320063
fix: client ignoring offline presence updates
sampaiodiego Feb 26, 2024
0c6d3db
prevent cache
sampaiodiego Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-doors-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fix web UI not showing users presence updating to offline
3 changes: 0 additions & 3 deletions apps/meteor/app/notifications/client/lib/Presence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,5 @@ type args = [username: string, statusChanged?: UserStatus, statusText?: string];
export const STATUS_MAP = [UserStatus.OFFLINE, UserStatus.ONLINE, UserStatus.AWAY, UserStatus.BUSY, UserStatus.DISABLED];

Meteor.StreamerCentral.on('stream-user-presence', (uid: string, [username, statusChanged, statusText]: args) => {
if (!statusChanged) {
return;
}
Comment thread
debdutdeb marked this conversation as resolved.
Resolved
Presence.notify({ _id: uid, username, status: STATUS_MAP[statusChanged as any], statusText });
});