Skip to content

test: make settings fully independent #31659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Feb 7, 2024
Merged

test: make settings fully independent #31659

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d982ea3
test: make settings fully independent
Feb 5, 2024
c8279c2
Merge branch 'develop' into test/decouple-settings
kodiakhq[bot] Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/meteor/tests/end-to-end/api/08-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect } from 'chai';
import { before, describe, it } from 'mocha';
import { before, describe, it, after } from 'mocha';

import { getCredentials, api, request, credentials } from '../../data/api-data.js';
import { updateSetting } from '../../data/permissions.helper';
Expand Down Expand Up @@ -87,9 +87,9 @@ describe('[Settings]', function () {
});

describe('With OAuth enabled', () => {
before((done) => {
updateSetting('Accounts_OAuth_Google', true).then(done);
});
before(() => updateSetting('Accounts_OAuth_Google', true));

after(() => updateSetting('Accounts_OAuth_Google', false));

it('should include the OAuth service in the response', (done) => {
// wait 3 seconds before getting the service list so the server has had time to update it
Expand All @@ -111,9 +111,9 @@ describe('[Settings]', function () {
});

describe('With OAuth disabled', () => {
before((done) => {
updateSetting('Accounts_OAuth_Google', false).then(done);
});
before(() => updateSetting('Accounts_OAuth_Google', false));

after(() => updateSetting('Accounts_OAuth_Google', false));

it('should not include the OAuth service in the response', (done) => {
// wait 3 seconds before getting the service list so the server has had time to update it
Expand Down