Skip to content

test: make outgoing integrations fully independent #31656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Mar 12, 2024
Merged

test: make outgoing integrations fully independent #31656

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00e0795
test: make outgoing integrations fully independent
Feb 5, 2024
2b525db
fix: prefer promise all
Feb 5, 2024
212b1ba
Merge branch 'develop' into test/decouple-outgoing-integrations
Mar 11, 2024
c283651
fix: suggestions from code review
Mar 11, 2024
b921238
Merge branch 'develop' into test/decouple-outgoing-integrations
kodiakhq[bot] Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions apps/meteor/tests/end-to-end/api/06-outgoing-integrations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { getCredentials, api, request, credentials } from '../../data/api-data.j
import { createIntegration, removeIntegration } from '../../data/integration.helper';
import { updatePermission } from '../../data/permissions.helper';
import { password } from '../../data/user';
import { createUser, login } from '../../data/users.helper';
import { createUser, deleteUser, login } from '../../data/users.helper';

describe('[Outgoing Integrations]', function () {
this.retries(0);
Expand All @@ -16,22 +16,24 @@ describe('[Outgoing Integrations]', function () {
let userCredentials;

before((done) => getCredentials(done));

before((done) => {
updatePermission('manage-incoming-integrations', [])
.then(() => updatePermission('manage-own-incoming-integrations', []))
.then(() => updatePermission('manage-own-outgoing-integrations', []))
.then(() => updatePermission('manage-outgoing-integrations', []))
.then(done);
before(async () => {
await Promise.all([
updatePermission('manage-incoming-integrations', []),
updatePermission('manage-own-incoming-integrations', []),
updatePermission('manage-own-outgoing-integrations', []),
updatePermission('manage-outgoing-integrations', []),
]);
});

after((done) => {
updatePermission('manage-incoming-integrations', ['admin'])
.then(() => updatePermission('manage-own-incoming-integrations', ['admin']))
.then(() => updatePermission('manage-own-outgoing-integrations', ['admin']))
.then(() => updatePermission('manage-outgoing-integrations', ['admin']))
.then(done);
});
after(async () =>
Promise.all([
updatePermission('manage-incoming-integrations', ['admin']),
updatePermission('manage-own-incoming-integrations', ['admin']),
updatePermission('manage-own-outgoing-integrations', ['admin']),
updatePermission('manage-outgoing-integrations', ['admin']),
deleteUser(user),
Comment thread
MarcosSpessatto marked this conversation as resolved.
]),
);

describe('[/integrations.create]', () => {
it('should return an error when the user DOES NOT have the permission "manage-outgoing-integrations" to add an outgoing integration', (done) => {
Expand Down Expand Up @@ -183,6 +185,7 @@ describe('[Outgoing Integrations]', function () {
});

it('should create an outgoing integration successfully', (done) => {
let integrationId;
request
.post(api('integrations.create'))
.set(credentials)
Expand All @@ -204,14 +207,14 @@ describe('[Outgoing Integrations]', function () {
.expect(200)
.expect((res) => {
expect(res.body).to.have.property('success', true);
integration._id = res.body.integration._id;
expect(res.body).to.have.nested.property('integration.name', 'Guggy');
expect(res.body).to.have.nested.property('integration.type', 'webhook-outgoing');
expect(res.body).to.have.nested.property('integration.enabled', true);
expect(res.body).to.have.nested.property('integration.username', 'rocket.cat');
expect(res.body).to.have.nested.property('integration.event', 'sendMessage');
integrationId = res.body.integration._id;
})
.end(done);
.end(() => removeIntegration(integrationId, 'outgoing').then(done));
});
});

Expand Down