Skip to content

test: fix flaky setGuestName test #31486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Jan 18, 2024
Merged

test: fix flaky setGuestName test #31486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-api.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,8 @@ test.describe('OC - Livechat API', () => {
await poLiveChat.onlineAgentMessage.type('this_a_test_message_from_visitor');
await poLiveChat.btnSendMessageToOnlineAgent.click();

await poAuxContext.poHomeOmnichannel.sidenav.openChat(registerGuestVisitor.name);

await test.step('Expect setGuestEmail to change a guest email', async () => {
await poLiveChat.page.evaluate(
(registerGuestVisitor) => window.RocketChat.livechat.setGuestName(`changed${registerGuestVisitor.name}`),
Expand All @@ -429,9 +431,7 @@ test.describe('OC - Livechat API', () => {
});

await test.step('Expect registered guest to have valid info', async () => {
await poAuxContext.poHomeOmnichannel.sidenav.openChat(registerGuestVisitor.name);

await expect(poAuxContext.poHomeOmnichannel.content.infoContactName).toContainText(`changed${registerGuestVisitor.name}`);
await expect(poAuxContext.poHomeOmnichannel.content.infoHeaderName).toContainText(`changed${registerGuestVisitor.name}`);
});
});

Expand Down
4 changes: 4 additions & 0 deletions apps/meteor/tests/e2e/page-objects/fragments/home-omnichannel-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,8 @@ export class HomeOmnichannelContent extends HomeContent {
get btnOnHoldConfirm(): Locator {
return this.modalOnHold.locator('role=button[name="Place chat On-Hold"]');
}

get infoHeaderName(): Locator {
return this.page.locator('.rcx-room-header').getByRole('heading');
}
}