Skip to content

feat: Rendering links with specific protocols in the User Info panel #31475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 6 commits into from
Feb 14, 2024
Merged

feat: Rendering links with specific protocols in the User Info panel #31475

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50f125e
fix: Rendering links and specific protocols in the UserInfo panel
Gustrb Jan 17, 2024
a1c776c
Merge branch 'develop' into fix/user-info-links-with-markdown-not-wor…
matheusbsilva137 Feb 2, 2024
c02614c
Create good-panthers-call.md
Feb 3, 2024
9ca7c32
increase the accepted protocols
yash-rajpal Feb 14, 2024
b7355ba
Merge branch 'develop' into fix/user-info-links-with-markdown-not-wor…
kodiakhq[bot] Feb 14, 2024
b8a70a9
oops
yash-rajpal Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/good-panthers-call.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

This fix allows links such as ones starting with "notes://" and other specific apps to be rendered in the User panel as they are in the messages
2 changes: 1 addition & 1 deletion apps/meteor/client/components/MarkdownText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const MarkdownText: FC<Partial<MarkdownTextParams>> = ({

let markedOptions: marked.MarkedOptions;

const schemes = 'http,https';
const schemes = 'http,https,Notes,ftp,ftps,tel,mailto,sms,cid';

switch (variant) {
case 'inline':
Expand Down