Skip to content

chore: add aria-label to Select Inputs at Engagement Dashboard #31249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jan 3, 2024
Merged

chore: add aria-label to Select Inputs at Engagement Dashboard #31249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abeef61
chore: add aria-label to Select Inputs at Engagement Dashboard
hugocostadev Dec 15, 2023
99cb4b6
Merge branch 'develop' into fix/engagement-dashboard-aria-labels
kodiakhq[bot] Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/meteor/ee/client/components/dashboards/PeriodSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,15 @@ const PeriodSelector = <TPeriod extends Period['key']>({ periods, value, name, o

const options = useMemo<[string, string][]>(() => periods.map((period) => [period, t(...getPeriod(period).label)]), [periods, t]);

return <Select name={name} options={options} value={value} onChange={(value): void => onChange(value as TPeriod)} />;
return (
<Select
name={name}
options={options}
value={value}
onChange={(value): void => onChange(value as TPeriod)}
aria-label={t('Select_period')}
/>
);
};

export default PeriodSelector;
7 changes: 6 additions & 1 deletion apps/meteor/ee/client/views/admin/engagementDashboard/EngagementDashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ const EngagementDashboardPage = ({ tab = 'users', onSelectTab }: EngagementDashb
return (
<Page background='tint'>
<PageHeader title={t('Engagement')}>
<Select options={timezoneOptions} value={timezoneId} onChange={(value) => handleTimezoneChange(String(value))} />
<Select
options={timezoneOptions}
value={timezoneId}
onChange={(value) => handleTimezoneChange(String(value))}
aria-label={t('Default_Timezone_For_Reporting')}
/>
</PageHeader>
<Tabs>
<Tabs.Item selected={tab === 'users'} onClick={handleTabClick('users')}>
Expand Down
7 changes: 6 additions & 1 deletion apps/meteor/ee/client/views/admin/engagementDashboard/users/BusiestChatTimesSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ const BusiestChatTimesSection = ({ timezone }: BusiestChatTimesSectionProps): Re
return (
<>
<EngagementDashboardCardFilter>
<Select options={timeUnitOptions} value={timeUnit} onChange={(value) => handleTimeUnitChange(String(value))} />
<Select
options={timeUnitOptions}
value={timeUnit}
onChange={(value) => handleTimeUnitChange(String(value))}
aria-label={t('Select_period')}
/>
</EngagementDashboardCardFilter>
<Content
displacement={displacement}
Expand Down
3 changes: 2 additions & 1 deletion apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4650,6 +4650,7 @@
"Select_atleast_one_channel_to_forward_the_messsage_to": "Select at least one channel to forward the message to",
"Select_user": "Select user",
"Select_users": "Select users",
"Select_period": "Select period",
"Selected_agents": "Selected agents",
"Selected_by_default": "Selected by default",
"Selected_departments": "Selected Departments",
Expand Down Expand Up @@ -6258,4 +6259,4 @@
"Seat_limit_reached": "Seat limit reached",
"Seat_limit_reached_Description": "Your workspace reached its contractual seat limit. Buy more seats to add more users.",
"Buy_more_seats": "Buy more seats"
}
}