Skip to content

fix: Livechat Reactivity issues with createOrUpdateGuest (6.4.8 version) #30993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Nov 20, 2023
Merged

fix: Livechat Reactivity issues with createOrUpdateGuest (6.4.8 version) #30993

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
848086e
fix: Livechat Reactivity issues with createOrUpdateGuest
MartinSchoeler Nov 16, 2023
cdcafae
Merge branch 'release-6.4.7' into fix-livechat-api
Harmeet221 Nov 17, 2023
c66ee16
fix sub
MartinSchoeler Nov 17, 2023
5213815
Merge branch 'release-6.4.8' into fix-livechat-api
kodiakhq[bot] Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/livechat/src/lib/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const createOrUpdateGuest = async (guest) => {
token && (await store.setState({ token }));
const { visitor: user } = await Livechat.grantVisitor({ visitor: { ...guest } });
store.setState({ user });
await loadConfig();
};

const updateIframeGuestData = (data) => {
Expand Down Expand Up @@ -141,8 +142,7 @@ const api = {
if (token === localToken) {
return;
}
createOrUpdateGuest({ token });
await loadConfig();
await createOrUpdateGuest({ token });
},

setGuestName(name) {
Expand All @@ -153,8 +153,8 @@ const api = {
updateIframeGuestData({ email });
},

registerGuest(data = {}) {
if (typeof data !== 'object') {
async registerGuest(data) {
if (!data || typeof data !== 'object') {
return;
}

Expand All @@ -166,7 +166,9 @@ const api = {
api.setDepartment(data.department);
}

createOrUpdateGuest(data);
Livechat.unsubscribeAll();

await createOrUpdateGuest(data);
},

async setLanguage(language) {
Expand Down