Skip to content

fix: Use correct mediaTypeWhitelist instead of wrong func on SMS providers #29706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 4 commits into from
Aug 22, 2023
Merged

fix: Use correct mediaTypeWhitelist instead of wrong func on SMS providers #29706

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ce9e05
Use correct property instead of wrong non implemented func
KevLehman Jul 3, 2023
9ab3737
Merge branch 'develop' into fix/twilio-media-type-whitelist
KevLehman Jul 28, 2023
a8cf391
show more errors on failures
KevLehman Jul 28, 2023
87aaa63
oh god
KevLehman Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions apps/meteor/server/services/omnichannel-integrations/providers/twilio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export class Twilio implements ISMSProvider {
size: filesize(MAX_FILE_SIZE),
lng,
});
} else if (!fileUploadIsValidContentType(type, this.fileUploadMediaTypeWhiteList())) {
} else if (!fileUploadIsValidContentType(type, this.mediaTypeWhiteList)) {
reason = i18n.t('File_type_is_not_accepted', { lng });
}

Expand Down Expand Up @@ -181,10 +181,6 @@ export class Twilio implements ISMSProvider {
};
}

fileUploadMediaTypeWhiteList(): any {
throw new Error('Method not implemented.');
}

response(): SMSProviderResponse {
return {
headers: {
Expand Down
6 changes: 1 addition & 5 deletions apps/meteor/server/services/omnichannel-integrations/providers/voxtelesys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class Voxtelesys implements ISMSProvider {
size: filesize(MAX_FILE_SIZE),
lng,
});
} else if (!fileUploadIsValidContentType(type, this.fileUploadMediaTypeWhiteList())) {
} else if (!fileUploadIsValidContentType(type, this.mediaTypeWhiteList)) {
reason = i18n.t('File_type_is_not_accepted', { lng });
}

Expand Down Expand Up @@ -151,10 +151,6 @@ export class Voxtelesys implements ISMSProvider {
}
}

fileUploadMediaTypeWhiteList(): any {
throw new Error('Method not implemented.');
}

response(): SMSProviderResponse {
return {
headers: {
Expand Down