Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rocketchat-irc #296

Merged
merged 1 commit into from
Jul 13, 2015
Merged

Update rocketchat-irc #296

merged 1 commit into from
Jul 13, 2015

Conversation

haosdent
Copy link
Contributor

  • Auto create direct room when not exist
  • Sync room member list between irc and rocketchat
  • Avoid callback loop

@haosdent haosdent force-pushed the master branch 3 times, most recently from f7307fe to 379782e Compare July 13, 2015 15:23
@haosdent
Update rocketchat-irc
7e1ec03 
* Auto create direct room when not exist
* Sync room member list between irc and rocketchat
* Avoid callback loop
* Add logoutCleanUp hook
* Add login error check
* Add connect when close
engelgabriel added a commit that referenced this pull request Jul 13, 2015
@engelgabriel
Merge pull request #296 from haosdent/master
acf104c 
Update rocketchat-irc
@engelgabriel engelgabriel merged commit acf104c into RocketChat:master Jul 13, 2015
@engelgabriel
Copy link
Member

Had to remove username: formData.name from the register method.

There are a few tests on the /server/methods/setUsername.coffee that need to be considered.

Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this pull request Apr 6, 2018
@mrsimpson
Open Smarti-Tab in requests and livechats (RocketChat#296)
9fa2f4f
This was referenced Mar 16, 2020
Merged
Open
Open
shubhsherl pushed a commit to shubhsherl/Rocket.Chat that referenced this pull request Jun 26, 2020
@kb0304
Merge pull request RocketChat#296 from Shailesh351/sb_push_ui
8ec22c8 
Initial Push Notification Message UI
This was referenced Nov 18, 2020
Open
Open
Open
@sitedata sitedata mentioned this pull request Mar 8, 2021
Open
@toshanmugaraj toshanmugaraj mentioned this pull request Mar 8, 2021
Open
@timtheguy timtheguy mentioned this pull request Mar 8, 2021
Open
This was referenced Sep 15, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haosdent @engelgabriel