Bad word filter Feature (Ready to Use) :D

[x5engine]

Bad Words Filter (Feature)

Here is the bad words filter feature where you can filter all the bad words :

• No need to add them just Enable/Disable in Settings-Message (default = enabled)
• You can any words to filter and as much as you want ;)
• It's Awesome you can try with some phrases like <censored> Only for test purposes :D

Try and enjoy :)

[x5engine]

result would be ******* ************ with a big **** and nice ***** and I hate your ******* ****

[x5engine]

@rodrigok it works and I tested it many times bro ;)

[engelgabriel]

@capensisma this is an automated test o code quality, from https://www.codacy.com/app/RocketChat/Rocket-Chat/pullRequest?prid=220222

[x5engine]

@engelgabriel there is nothing to be improved there, so ... and it works well and as intended

[x5engine]

CI is good though https://travis-ci.org/RocketChat/Rocket.Chat/builds/124090832

[engelgabriel]

It may work well.. this is not the point.

The code QUALITY is bad because it doens't follow the standards.

[x5engine]

code QUALITY is bad? okay show me better then!

[engelgabriel]

What editor do you use? Can you install ESlint?

[x5engine]

I can in the cloud c9.io that's all why is the editor related to this?

[rodrigok]

@capensisma a better code syntax looks like:

const Filter = Npm.require('bad-words');

RocketChat.callbacks.add('beforeSaveMessage', function(message) {

    if (RocketChat.settings.get('Message_AllowBadWordsFilter')) {
        const badWordsList = RocketChat.settings.get('Message_BadWordsFilterList');

        let filter;

        //Add words to the blacklist
        if (!!badWordsList && badWordsList.length) {
            filter = new Filter({ list: badWordsList.split(',') });
        } else {
            filter = new Filter();
        }

        message.msg = filter.clean(message.msg);
    }

    return message;
}, 1);

Your current code is:

var Filter = Npm.require('bad-words');

    RocketChat.callbacks.add( 'beforeSaveMessage' , function(message){
        // console.log(message)

        if( RocketChat.settings.get('Message_AllowBadWordsFilter') )
            {

                var badWordsList = RocketChat.settings.get('Message_BadWordsFilterList');
                    // console.log(badWordsList)
                    //Add words to the blacklist
                    if(!!badWordsList && badWordsList.length)
                        {   
                            // console.log(badWordsList)
                            var filter = new Filter({ list: badWordsList.split(',') });
                        }
                    else
                        var filter = new Filter();
                message.msg = filter.clean(message.msg);

            }
    return message;

    },1);

We have a lot of ESLint rules to keep the code quality, you can use the ESLint command line tool to check your code and you can integrate the ESLint with your code editor to get error hints.

[rodrigok]

Issue found: Expected '{' and instead saw 'var'.

[rodrigok]

Issue found: Variable 'filter' is already declared in line 16.

[rodrigok]

Issue found: "filter" is already defined

[x5engine]

What's the ETA on this? will never be merged or what? bros?

[geekgonecrazy]

@capensisma can you take a look at the few code tweaks as included in the previous comment, and the comments on the commit?

All are listed here above. We review carefully anything that will directly interact with the messages. We want to make sure to prevent any issues from coming up. Fixing the above mentioned would give us more comfort :)

Appreciate the understanding!

[x5engine]

I swear to God there is nothing to change or fix here, its just the codacy doesn't like the indentations or something and it's says var or like Keyword "if" must be followed by whitespace. this is code quality for CoffeeScript not Pure Javascript bros C'mon!

[geekgonecrazy]

@capensisma The thing you have to remember about code you contribute. Once you check it in to the project and we accept it, you no longer have to maintain it. We do. Its because of this we are trying to improve code quality. This makes our life easier.

But no worries.. I'll take care of this. Thanks for contributing.

[geekgonecrazy]

We'll review and merge via #2991