fix: Sidebar vars #29070
Merged
fix: Sidebar vars #29070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliajforesti
force-pushed
the
fix/sidebar-var
branch
from
d6f9e15 to
90ed740
Compare
juliajforesti
force-pushed
the
fix/sidebar-var
branch
from
90ed740 to
86e2c8e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #29070 +/- ##
===========================================
+ Coverage 41.14% 46.86% +5.71%
===========================================
Files 691 709 +18
Lines 12999 13207 +208
Branches 2158 2195 +37
===========================================
+ Hits 5348 6189 +841
+ Misses 7365 6709 -656
- Partials 286 309 +23
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
previously approved these changes
May 4, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSAR-11
Proposed changes (including videos or screenshots)
--sidebar-backgroundvar to refer to correct token--sidebar-item-text-colorvar with correct tokenThese reflect on electron updating the web app sidebar to use the same colors as the chats list.
Electron fix: 2655
Issue(s)
Steps to test or reproduce
Further comments