-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Regression: Change names of requested apps sorting options #28312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the name of the requested app-related sorting options to cause less confusion regarding their expected behavior and solved some UX problems with the initial state of the sorting filter when on different marketplace pages. Also fixed some typos.
Codecov Report
@@ Coverage Diff @@
## develop #28312 +/- ##
===========================================
- Coverage 44.94% 44.92% -0.02%
===========================================
Files 771 771
Lines 14979 14979
Branches 2092 2092
===========================================
- Hits 6732 6730 -2
- Misses 7950 7951 +1
- Partials 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not JUST check if isRequested on the initial setSortFilterStructure?
no need at all for this useEffect
Because what you are describing, if I understood correctly, would only work on the first access of this component and would not change to the "unread requested first" sorting when accessing the requested apps page. |
Proposed changes (including videos or screenshots)
Jira task: MKP-253
Changed the name of the requested app-related sorting options to cause less confusion regarding their expected behavior and solved some UX problems with the initial state of the sorting filter when on different marketplace pages. Also fixed some typos.

Demo image:
Issue(s)
Steps to test or reproduce
Further comments