Skip to content

Conversation

@rique223
Copy link
Contributor

@rique223 rique223 commented Mar 7, 2023

Proposed changes (including videos or screenshots)

Jira task: MKP-253

Changed the name of the requested app-related sorting options to cause less confusion regarding their expected behavior and solved some UX problems with the initial state of the sorting filter when on different marketplace pages. Also fixed some typos.
Demo image:
image

Issue(s)

Steps to test or reproduce

Further comments

Changed the name of the requested app-related sorting options to cause less confusion regarding their expected behavior and solved some UX problems with the initial state of the sorting filter when on different marketplace pages. Also fixed some typos.
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #28312 (5299324) into develop (9114f28) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28312      +/-   ##
===========================================
- Coverage    44.94%   44.92%   -0.02%     
===========================================
  Files          771      771              
  Lines        14979    14979              
  Branches      2092     2092              
===========================================
- Hits          6732     6730       -2     
- Misses        7950     7951       +1     
- Partials       297      298       +1     
Flag Coverage Δ
e2e 44.89% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 marked this pull request as ready for review March 7, 2023 18:58
@rique223 rique223 requested a review from a team as a code owner March 7, 2023 18:58
@PedroRorato PedroRorato self-requested a review March 7, 2023 19:32
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not JUST check if isRequested on the initial setSortFilterStructure?
no need at all for this useEffect

@rique223
Copy link
Contributor Author

rique223 commented Mar 7, 2023

why not JUST check if isRequested on the initial setSortFilterStructure?
no need at all for this useEffect

Because what you are describing, if I understood correctly, would only work on the first access of this component and would not change to the "unread requested first" sorting when accessing the requested apps page.

@rique223 rique223 requested a review from dougfabris March 7, 2023 19:56
@casalsgh casalsgh added this to the 6.0.0 milestone Mar 7, 2023
@dougfabris dougfabris changed the title Chore: Change names of requested apps sorting options Regression: Change names of requested apps sorting options Mar 7, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 7, 2023
@kodiakhq kodiakhq bot merged commit e78bd95 into develop Mar 8, 2023
@kodiakhq kodiakhq bot deleted the chore/marketplace-sort-requested branch March 8, 2023 00:29
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge type: regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants