Skip to content

Conversation

@guijun13
Copy link
Contributor

@guijun13 guijun13 commented Feb 28, 2023

Proposed changes (including videos or screenshots)

  • Close the 'too long message to attachment' modal before opening the 'file upload' modal

Issue(s)

Steps to test or reproduce

Further comments

TC-506

@guijun13 guijun13 added this to the 6.0.0 milestone Feb 28, 2023
@guijun13 guijun13 marked this pull request as ready for review February 28, 2023 19:45
@guijun13 guijun13 requested a review from a team as a code owner February 28, 2023 19:45
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #28212 (8524293) into develop (9ed8424) will increase coverage by 7.86%.
The diff coverage is 47.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28212      +/-   ##
===========================================
+ Coverage    32.28%   40.15%   +7.86%     
===========================================
  Files          627      720      +93     
  Lines        12488    14276    +1788     
  Branches      1848     2044     +196     
===========================================
+ Hits          4032     5732    +1700     
- Misses        8258     8278      +20     
- Partials       198      266      +68     
Flag Coverage Δ
e2e 40.11% <47.50%> (+7.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@kodiakhq kodiakhq bot merged commit 6035146 into develop Mar 1, 2023
@kodiakhq kodiakhq bot deleted the fix/long-msg-modal branch March 1, 2023 17:06
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge type: regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants