Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 15, 2023

Proposed changes (including videos or screenshots)

Fixed faulty logic

Issue(s)

Steps to test or reproduce

  • Create a room
  • Go to notification preferences in that room
  • Disable "Mark as Unread"
  • Enable "Show badge for mentions"

A 0 will appear when there's no unread messages.

Further comments

TC-475

@gabriellsh gabriellsh requested a review from a team as a code owner February 15, 2023 20:22
@tassoevan tassoevan added this to the 6.0.0 milestone Feb 15, 2023
@ggazzo ggazzo merged commit 33eb522 into develop Feb 16, 2023
@ggazzo ggazzo deleted the fix/0 branch February 16, 2023 03:16
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants