Skip to content

[FIX] Custom fields does not appear on the registration form #28031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 8 commits into from
Feb 15, 2023
Merged

[FIX] Custom fields does not appear on the registration form #28031

sampaiodiego merged 8 commits into from
Feb 15, 2023

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Feb 14, 2023 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/OC-540

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #28031 (1296b40) into develop (f85d57a) will increase coverage by 1.19%.
The diff coverage is n/a.

❗ Current head 1296b40 differs from pull request most recent head a6e2973. Consider uploading reports for the commit a6e2973 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28031      +/-   ##
===========================================
+ Coverage    43.77%   44.96%   +1.19%     
===========================================
  Files          790      763      -27     
  Lines        15261    14758     -503     
  Branches      2085     2010      -75     
===========================================
- Hits          6680     6636      -44     
+ Misses        8300     7843     -457     
+ Partials       281      279       -2
Flag Coverage Δ
e2e 44.96% <ø> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 marked this pull request as ready for review February 14, 2023 12:35
@murtaza98 murtaza98 requested review from a team as code owners February 14, 2023 12:35
@murtaza98 murtaza98 added this to the 6.0.0 milestone Feb 14, 2023
KevLehman
KevLehman previously requested changes Feb 14, 2023
View reviewed changes
@murtaza98 murtaza98 requested a review from KevLehman February 14, 2023 14:31
@murtaza98 murtaza98 dismissed KevLehman’s stale review February 14, 2023 14:31

done, Thks Kevin :)

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 14, 2023
KevLehman
KevLehman previously approved these changes Feb 14, 2023
View reviewed changes
sampaiodiego
sampaiodiego requested changes Feb 15, 2023
View reviewed changes
sampaiodiego
sampaiodiego reviewed Feb 15, 2023
View reviewed changes
sampaiodiego
sampaiodiego reviewed Feb 15, 2023
View reviewed changes
@sampaiodiego sampaiodiego merged commit 65565a2 into develop Feb 15, 2023
@sampaiodiego sampaiodiego deleted the livechat/cf-not-working branch February 15, 2023 22:55
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
Merged
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@KevLehman KevLehman KevLehman left review comments

Assignees

No one assigned

Labels

squad: omnichannel stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@murtaza98 @sampaiodiego @KevLehman @Harmeet221