Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

TC-405

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #27962 (2e49604) into develop (ee55b3e) will increase coverage by 10.54%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #27962       +/-   ##
============================================
+ Coverage    34.25%   44.79%   +10.54%     
============================================
  Files          660      766      +106     
  Lines        13365    14937     +1572     
  Branches      1968     2080      +112     
============================================
+ Hits          4578     6691     +2113     
+ Misses        8553     7952      -601     
- Partials       234      294       +60     
Flag Coverage Δ
e2e 44.75% <66.66%> (+10.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review February 8, 2023 17:29
@yash-rajpal yash-rajpal requested a review from a team as a code owner February 8, 2023 17:29
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you send a message in the thread, it still shows the placeholder.

@yash-rajpal yash-rajpal changed the title [FIX] Use main thread message from meteor mongo collections Regression: run clientMessageRecieved hooks on thread main message Mar 1, 2023
@yash-rajpal yash-rajpal added this to the 6.0.0 milestone Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 1, 2023
@ggazzo ggazzo merged commit 42b3154 into develop Mar 2, 2023
@ggazzo ggazzo deleted the e2e-thread-main-message branch March 2, 2023 04:41
gabriellsh added a commit that referenced this pull request Mar 6, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Apps provider not handling apps lists correctly (#28264)
  Regression: Fix intermitent apps engine startup (#28254)
  Regression: Client is not loading new settings from server (#28248)
  Regression: Adjusted departments upsell modal to check for licence and modules (#28246)
  Regression: message-parse version update (#28245)
  [FIX] Notify apps engine event through ms api (#28169)
  Chore: Add extra stats for omnichannel video calling (#28211)
  Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233)
  Regression: Change text of buttons tooltips on custom content homepage block (#28094)
  Regression: run clientMessageRecieved hooks on thread main message (#27962)
  Regression: Jump to message not working (#28163)
  Regression: Hide price and category filters when inside of private apps page (#28188)
  [BREAK] Remove support to deprecated typing event (#28234)
  Regression: Fix app status filter not working in private apps page (#28198)
  Regression: UiKit message surface styles (#28213)
  [FIX] Search list missing key parameter (#28230)
  Regression: broken message exhibition when edited (#28180)
  Regression: EnableUnlimitedApps button action (#28221)
  Regression: Update Composer Formatters Translation Keys (#28228)
  Regression: EmojiPicker missing shadow on dark mode (#28236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge type: regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants