Skip to content

Conversation

@tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #27909 (35d0b5f) into develop (ea59e1d) will decrease coverage by 0.86%.
The diff coverage is 75.82%.

❗ Current head 35d0b5f differs from pull request most recent head 41d98ac. Consider uploading reports for the commit 41d98ac to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27909      +/-   ##
===========================================
- Coverage    43.07%   42.22%   -0.86%     
===========================================
  Files          815      841      +26     
  Lines        17090    17610     +520     
  Branches      1938     2064     +126     
===========================================
+ Hits          7362     7435      +73     
- Misses        9462     9899     +437     
- Partials       266      276      +10     
Flag Coverage Δ
e2e 42.22% <75.82%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/cached-collections branch from 35d0b5f to 41d98ac Compare January 31, 2023 19:33
@tassoevan tassoevan marked this pull request as ready for review February 1, 2023 01:17
@tassoevan tassoevan requested review from a team as code owners February 1, 2023 01:17
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from apps side

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 1, 2023
@ggazzo ggazzo merged commit 536eb15 into develop Feb 1, 2023
@ggazzo ggazzo deleted the refactor/cached-collections branch February 1, 2023 17:40
gabriellsh added a commit that referenced this pull request Feb 6, 2023
….Chat into matrixSearch

* 'feat/federation-feat-2' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix: removing file wrongly merged on update merge
  [NEW] Federation search public rooms in the Matrix network (#27434)
  Chore: Refactor other kinds of message - Phase 2 (#27927)
  Chore: improve some e2e selectors (#27936)
  [NEW] Warning Popup reinforcing Zapier deprecation on Integrations Admin settings (#27744)
  Chore: Notify Marketplace on App Install (#27925)
  i18n: Language update from LingoHub 🤖 on 2023-01-23Z (#27814)
  [FIX][ENTERPRISE] DDP streamer sending data to destroyed streams (#27929)
  Chore: Migrate cached collections to TypeScript (#27909)
  i18n: Language update from LingoHub 🤖 on 2023-01-09Z (#27705)
  [FIX] Reduce re-subscription on `notify-room/user-activity` stream event (#27911)
  [FIX] Unread Message count not displayed for new messages in Omni-Rooms (#27539)
  Chore: Improve service's licence check (#27872)
  [IMPROVE] Livechat Persian translation (#27825)
  Chore(deps): Bump thehanimo/pr-title-checker from 1.3.4 to 1.3.6 (#27884)
  Chore: use useQuery in place of deprecated useEndpointData (#27673)
  Chore: Update Some Composer Icons (#27862)
  Regression: Undefined default message context (#27870)
  Chore: Remove OS version for device management (#27786)
  [BREAK] Remove less theming (#27647)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants